Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loose comparison in job_manager_get_listings() yields to empty result with PHP 8 #91

Open
mjaschen opened this issue Jun 14, 2022 · 0 comments
Open

Loose comparison in job_manager_get_listings() yields to empty result with PHP 8 #91

mjaschen opened this issue Jun 14, 2022 · 0 comments

Comments

@mjaschen
Copy link

An Ajax-call to /get_listings returns an empty result with PHP 8 while the same request works as expected with PHP 7.4.

Affected function: job_manager_get_listings():

0 != $params[ 'search_region' ]

When $params['search_region'] is '' the comparison evaluates to true with PHP <= 7 but to false with PHP >= 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjaschen