Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full payment release should not require amount #24

Open
szilardd opened this issue Feb 11, 2019 · 0 comments
Open

Full payment release should not require amount #24

szilardd opened this issue Feb 11, 2019 · 0 comments

Comments

@szilardd
Copy link

szilardd commented Feb 11, 2019

Based on documentation (https://reference.assemblypayments.com/?csharp#release-payment) when releasing a payment, you need to specify an amount if you want to do a partial release.

But if you want to do a full release, this should be optional because if there are fees involved, you don't really know the full amount available.

Shouldn't the amount be optional here or another overload wihout the releaseAmount parameter ? https://github.com/AssemblyPayments/promisepay-dotnet/blob/master/PromisePayDotNet/Interfaces/IItemRepository.cs#L39

The example request shown in the documentation seems to suggest this

var repo = container.Resolve<IItemRepository>();
repo.ReleasePayment("e57120ea-053d-11e6-b512-3e1d05defe78"); // no amount needed here

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant