You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For example if an error 500 or 408 occurs, what will happen in the SDK, will it throw an exception which has to be handled differently than the other type of errors that throw an ApiErrorsException ?
Would be good to handle all in the same way
Only statuses 400, 422 are handled and these are not provided in the ApiErrorsException class, you have to rely on the error message to determine the type of error if you want to give meaningful error messages to your users.
Would be good to include the status code at least in the ApiErrorsException object.
https://reference.assemblypayments.com/#error-codes
For example if an error 500 or 408 occurs, what will happen in the SDK, will it throw an exception which has to be handled differently than the other type of errors that throw an
ApiErrorsException
?Would be good to handle all in the same way
ApiErrorsException
class, you have to rely on the error message to determine the type of error if you want to give meaningful error messages to your users.Would be good to include the status code at least in the
ApiErrorsException
object.https://github.com/AssemblyPayments/promisepay-dotnet/blob/master/PromisePayDotNet/Implementations/AbstractRepository.cs#L113
https://github.com/AssemblyPayments/promisepay-dotnet/blob/master/PromisePayDotNet/Implementations/AbstractRepository.cs#L115
https://reference.assemblypayments.com/#error-codes
Would be good to document it in the API error codes page as well to be consistent
The text was updated successfully, but these errors were encountered: