From f8a155ee92ec6f6ac3e2d2a40e78e87586ccaafa Mon Sep 17 00:00:00 2001
From: Ashleigh Adams <ashleigh.k.adams@gmail.com>
Date: Sat, 25 Jun 2022 01:13:24 +0100
Subject: [PATCH] GitRepoInspector: Trim the response from git incase
 whitespace chars present

When running in Visual Studio's MsBuild, `git cat-file` may respond with various whitespace around, so ensure we're resilient to it.

Note, the char array is used because .NET does not treat all unicode whitespace chars as "trimmable," and git, when running under Visual Studio's environment, returns a zero width non-breaking space that Verlite was previously not expecting.
---
 src/Verlite.Core/GitRepoInspector.cs | 39 ++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/src/Verlite.Core/GitRepoInspector.cs b/src/Verlite.Core/GitRepoInspector.cs
index 92575ac..2b40645 100644
--- a/src/Verlite.Core/GitRepoInspector.cs
+++ b/src/Verlite.Core/GitRepoInspector.cs
@@ -134,6 +134,41 @@ private static IReadOnlyList<Commit> ParseCommitObjectParents(string commitObj)
 		private UTF8Encoding Encoding { get; } = new(
 			encoderShouldEmitUTF8Identifier: false,
 			throwOnInvalidBytes: false);
+
+		private char[] WhitespaceChars { get; } = new[]
+		{
+			'\t',
+			'\v',
+			'\f',
+			'\r',
+			'\n',
+			' ',
+			'\u0085', // NEXT LINE
+			'\u00A0', // NBSP
+			'\u1680', // OGHAM SPACE MARK
+			'\u2000', // EN QUAD
+			'\u2001', // EM QUAD
+			'\u2002', // EN SPACE
+			'\u2003', // EM SPACE
+			'\u2004', // THREE-PER-EM SPACE
+			'\u2005', // FOUR-PER-EM SPACE
+			'\u2006', // SIX-PER-EM SPACE
+			'\u2007', // FIGURE SPACE
+			'\u2008', // PUNCTUATION SPACE
+			'\u2009', // THIN SPACE
+			'\u200A', // HAIR SPACE
+			'\u2028', // LINE SEPARATOR
+			'\u2029', // PARAGRAPH SEPARATOR
+			'\u202F', // NARROW NBSP
+			'\u205F', // MEDIUM MATHEMATICAL SPACE
+			'\u3000', // IDEOGRAPHIC SPACE
+			'\u180E', // MONGOLIAN VOWEL SEPARATOR
+			'\u200B', // ZERO WIDTH SPACE
+			'\u200C', // ZERO WIDTH NON-JOINER
+			'\u200D', // ZERO WIDTH JOINER
+			'\u2060', // WORD JOINER
+			'\uFEFF', // ZERO WIDTH NON-BREAKING SPACE
+		};
 		private async Task<string?> CatFile(string type, string id)
 		{
 			await catFileSemaphore.WaitAsync();
@@ -182,7 +217,7 @@ private static IReadOnlyList<Commit> ParseCommitObjectParents(string commitObj)
 						throw new UnknownGitException("The git cat-file process timed out.");
 
 					var result = await gotBack;
-					if (result != "  missing")
+					if (result.Trim(WhitespaceChars) != "missing")
 						throw new UnknownGitException($"The git cat-file process returned unexpected output: {result}");
 				}
 
@@ -199,7 +234,7 @@ private static IReadOnlyList<Commit> ParseCommitObjectParents(string commitObj)
 
 				string line = await readLineTask;
 				Log?.Verbatim($"git cat-file > {line}");
-				string[] response = line.Split(' ');
+				string[] response = line.Trim(WhitespaceChars).Split(' ');
 
 
 				if (response[0] != id)