From 644edde34f1e0446296be2cf60d004fbd36056f4 Mon Sep 17 00:00:00 2001
From: Willian Galvani <williangalvani@gmail.com>
Date: Mon, 20 Nov 2023 09:03:56 -0300
Subject: [PATCH] CI: add test for node 12 through 20

---
 .github/workflows/test.yml | 48 ++++++++++++++++++++++++++++++++++++++
 generator/gen_js.sh        |  2 +-
 test_gen_js.sh             |  2 +-
 3 files changed, 50 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index d3be94302..ca682f80f 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -84,3 +84,51 @@ jobs:
       - name: Test with pytest
         run: |
           python -m pytest
+
+
+  node-tests:
+    name: Node ${{ matrix.node-version }} test
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: ['12', '14', '16', '18', '20']
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: 'recursive'
+      - name: Set up Python 3.8
+        uses: actions/setup-python@v2
+        with:
+          python-version: 3.8
+      - name: Install dependencies
+        run: |
+          pip install future lxml
+      - uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Install mavlink message
+        run: |
+          git clone https://github.com/ArduPilot/mavlink.git
+          ln -s $PWD/mavlink/message_definitions ../
+      - name: Install js dependencies
+        run: |
+          cd "generator/javascript"
+          npm ci
+          echo $PWD
+          git remote -v
+          git status
+          npm list || true
+
+      - name : Test mavlink
+        run: |
+          ./test_gen_js.sh
+          ls
+          echo "changing directory" || true
+          cd generator/javascript
+          echo "running npm list" || true
+          npm list || true
+          echo "running npm ci" || true
+          npm ci
+          echo "running npm test" || true
+          npm test
diff --git a/generator/gen_js.sh b/generator/gen_js.sh
index b0bbc8e4b..b618fdeb6 100755
--- a/generator/gen_js.sh
+++ b/generator/gen_js.sh
@@ -38,7 +38,7 @@ for protocol in 1.0 2.0; do
     "devDependencies" : {
       "should" : "",
       "mocha" : "",
-      "sinon" : ""
+      "sinon" : 17.0.0"
     }
 }
 EOF
diff --git a/test_gen_js.sh b/test_gen_js.sh
index 13baf9658..14cf774d1 100755
--- a/test_gen_js.sh
+++ b/test_gen_js.sh
@@ -65,7 +65,7 @@ test -z "$MDEF" && MDEF="../message_definitions"
      # need to install the bindings first to test them?
     printf "${RED}Installing just-generated npm package...${NC}\n\n"
     cd generator/javascript
-    npm install 2>/dev/null > /dev/null
+    npm ci 2>/dev/null > /dev/null
     cd ../..
 
    printf "${RED}JS-NextGen PRETEST setup done.${NC}\n\n"