-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Support negative RPM for dynamic harmonic notch #28303
Comments
Certainly some judicious fabsf() would probably fix this and would be easy to do. |
Please can you try |
Yeah, I will look into it today. I don't have any familiarity with the filtering classes, but I suppose this will be a good introduction. |
Did you see the PR I did? |
Nope, just saw it. Will try your PR now. |
Copter 4.5.6
Some specifications allow ESC telemetry to send negative RPM if the motor is spinning backwards (or just clockwise vs. counter-clockwise, as in my case), e.g. DroneCAN esc status message. RPM-tracking notches do not use negative RPM and they will just sit at the minimum frequency:
![image](https://private-user-images.githubusercontent.com/22406196/373510523-6e61ef29-186b-48c8-9359-bb7272332b6c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDgxMjAsIm5iZiI6MTczOTYwNzgyMCwicGF0aCI6Ii8yMjQwNjE5Ni8zNzM1MTA1MjMtNmU2MWVmMjktMTg2Yi00OGM4LTkzNTktYmI3MjcyMzMyYjZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4MjM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwMDk2MTBmZTBkMjA0NTQyZGQwOGI5YTI2NjcxNWRjNjU2YjEwYTZhOGVmZTAwZDljZTFiNmE0YWRkNWNiYzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.J2c7Go4b-37LCHbQN_RovppWgwpPNtsIttrJna8PUUY)
Suggestion:
I suppose the naive solution of using the absolute value of RPM would suffice?
Platform
[ ] All
[ ] AntennaTracker
[ x ] Copter
[ x ] Plane
[ ] Rover
[ ] Submarine
The text was updated successfully, but these errors were encountered: