You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having parameter THROTTLE_NUDGE set to 1, throttle stick have no effect on airspeed target value when in GUIDED mode while have an expected effect in AUTO mode.
Plane 4.3.8
Quadplane
CUAV X7 Pro Plus
The issue is probably dew to use of is_zero in navigation.cpp:
#if OFFBOARD_GUIDED == ENABLED
if (control_mode == &mode_guided && !is_zero(guided_state.target_airspeed_cm) && (airspeed_nudge_cm != 0)) {
airspeed_nudge_cm = 0; //airspeed_nudge_cm forced to zero
}
#endif
which is not correct in this case, cause guided_state.target_airspeed_cm initiates to -1
other parts of code uses comparison to 0.0 instead, which is correct.
The text was updated successfully, but these errors were encountered:
rmackay9
changed the title
THROTTLE_NUDGE doesn't work in GUIDED Mode
Plane: THROTTLE_NUDGE doesn't work in GUIDED Mode
Jan 29, 2024
A PR to fix that would be great. We should bring them all in line, I see 3 places its used, here we have !is_zero, > 0 and for logging is_positive. They should probably all be is_positive.
I've added a PR #26107, but it didn't pass plane SITL tests, however have passed quadplane tests.
Loking at logs showed some issues with fence handling (I can't imagine how it is related) and an issue with change altitude command in GUIDED mode, which is directly related to particular changes of code.
Plane didn't climb from 35 to 49 meters at some time, but could this be dew not neutral throttle, and low climb rate for this reason?
Could please somebody review the PR, my SITL logs and testing logs to point me where to move forward?
Having parameter THROTTLE_NUDGE set to 1, throttle stick have no effect on airspeed target value when in GUIDED mode while have an expected effect in AUTO mode.
Plane 4.3.8
Quadplane
CUAV X7 Pro Plus
The issue is probably dew to use of
is_zero
in navigation.cpp:which is not correct in this case, cause
guided_state.target_airspeed_cm
initiates to -1other parts of code uses comparison to 0.0 instead, which is correct.
The text was updated successfully, but these errors were encountered: