Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write needed video frames #56

Open
Firepal opened this issue Apr 2, 2023 · 0 comments
Open

Only write needed video frames #56

Firepal opened this issue Apr 2, 2023 · 0 comments

Comments

@Firepal
Copy link
Collaborator

Firepal commented Apr 2, 2023

This is a proposal from @mayhair in #11:

I also believe that once the frames needed to build the video are chosen, the useless ones can be immediately deleted before the build starts.

This is kind of the idea behind the new "mem_decay" mode, but it could also work for the default "write frames to disk" mode.

I would implement this as a list of ranges generated from the best matches. We sort the best matches, then create range() objects, then call ffmpeg for each range of frames we need generated.

@Firepal Firepal changed the title Only write needed video frames in disk mode Only write needed video frames Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant