Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author searches include other media types #8

Open
rchrd2 opened this issue Nov 6, 2017 · 4 comments
Open

Author searches include other media types #8

rchrd2 opened this issue Nov 6, 2017 · 4 comments

Comments

@rchrd2
Copy link
Contributor

rchrd2 commented Nov 6, 2017

The query needs to be updated to be something like collection:texts AND ${query}.

@rchrd2
Copy link
Contributor Author

rchrd2 commented Nov 6, 2017

tagging: @hornc

@hornc
Copy link
Contributor

hornc commented Nov 6, 2017

Ah, I was replicating the IA 'author' link query -- now I see why the property is 'creator' rather than 'author'!

Can we make the Search.jsx search only for collection:texts, or perhaps collection:(inlibrary) (which all the category headings use)? I was trying to leverage the generic search functionality, but having to specifically limit to books every time seems unnecessary for a books interface :)

@rchrd2
Copy link
Contributor Author

rchrd2 commented Nov 6, 2017

inlibrary is only books that are lendable
texts is a superset, which also includes public domain books

Maybe we should have something like a "Query" class. Which has some functions to generate queries.

Also, the /search/ endpoint could probably take two types of queries.

/search/?q=Simple+Term
/search/?q=collection:inlibrary+term&type=solr

Update: Change the search routes can be done separately. It's not directly tied to this issue.

@rchrd2
Copy link
Contributor Author

rchrd2 commented Nov 6, 2017

Looks like we should also always have mediatype:texts because I noticed a collection in the search result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants