Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter API key preventing PR? #20

Open
amir-zeldes opened this issue May 10, 2018 · 1 comment
Open

Twitter API key preventing PR? #20

amir-zeldes opened this issue May 10, 2018 · 1 comment

Comments

@amir-zeldes
Copy link
Collaborator

I'm having trouble becoming even with arborator-server/dev because I can't commit this file:

arborator-server/config.py

This means that PRs from my fork to fix #19 are getting conflicts. A GitHub bot is e-mailing me saying "GitGuardian detected an API key from Twitter". It appears the file does contain a Twitter API key, not sure whose, so it's probably a good idea to clean this up on origin dev (and shut down the API key).

@kimgerdes can you remove this file from dev if it's not needed for anything? I can also PR into stable if you like, that doesn't conflict. I need to edit project.cgi to resolve #19 .

@kimgerdes
Copy link
Member

the dev version is not working right now. the twitter login was actually just one of the login version we wanted to have there (with authomatic). only twitter actually worked. we'll have a completely new dev version soon.
so yes, please, go for stable, i'll accept!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants