fix warnings #309
Merged
fix warnings #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-rauch
force-pushed
the
fix_warnings
branch
16 times, most recently
from
f1688fd to
9c0790b
Compare
christian-rauch
force-pushed
the
fix_warnings
branch
4 times, most recently
from
50c3e24 to
d90c57a
Compare
christian-rauch
force-pushed
the
fix_warnings
branch
from
b576b72 to
4ea1009
Compare
christian-rauch
force-pushed
the
fix_warnings
branch
from
4ea1009 to
0720cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables and fixes a couple of warnings throughout the code base. All warnings are reported as errors to make sure that those are not introduced again.
Note: This PR removes unused parameters from function declarations and therefore breaks API with the previous version (3.3). Therefore, the next release has to bump the minor version.