Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge multi-byte characters password patch #323

Open
md-work opened this issue Nov 30, 2023 · 0 comments
Open

merge multi-byte characters password patch #323

md-work opened this issue Nov 30, 2023 · 0 comments

Comments

@md-work
Copy link

md-work commented Nov 30, 2023

===> Please merge 39d0629 into master, so it gets into the next release!

I've used the patch for several years and it works very well!
It would be great if I can stop using a custom build for that.

 

Looks like this patch for multi-byte characters passwords has accidentally only been merged into Aorimn:develop but not into master. @nevun points this out in the closed pull request #118 (comment)

By random sample I've looked at the user_key function in user_pass.c v0.7.3 and it doesn't contain the patch.
Patch: 39d0629dcfde3b911875643090cecd4cf106c680 -> src/accesses/user_pass/user_pass.c#L248
v0.7.3: v0.7.3/src/accesses/user_pass/user_pass.c#L248

Wrongly closed original ticket: #113

robert-scheck added a commit to robert-scheck/dislocker that referenced this issue Jan 5, 2025
…mn#113)

Using iconv() to convert the password from the local character set to UTF-16LE used by BitLocker.

Ported Aorimn#118 from develop (merged) to the master branch.

Co-authored-by: José Luis González García <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant