Skip to content
This repository was archived by the owner on Apr 15, 2021. It is now read-only.

Suppport for Laravel Dusk #2

Open
aidan-casey opened this issue Jul 30, 2020 · 1 comment
Open

Suppport for Laravel Dusk #2

aidan-casey opened this issue Jul 30, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@aidan-casey
Copy link
Member

The goal of this package is to give developers full functionality of Laravel from development to production. Considering this, we should probably add support for Laravel Dusk.

To run Selenium in a separate container, this would require the following:

  • laravel.conf becomes default.conf making it the default response of any Nginx request (not a bad thing anyway).
  • Selenium docker images included in docker-compose.yaml
  • Users would need to customize tests/DuskTestCase.php to use the selenium endpoint.
  • Customized APP_URL env variable so Selenium could browse to the application.

There is also the option to run Selenium in the workspace container. This would require the following:

  • laravel.conf becomes default.conf making it the default response of any Nginx request (not a bad thing anyway).
  • Selenium hub and driver install in the workspace container.
  • Customized APP_URL env variable for workspace container only so Selenium could browse to the application.

I am creating this here so we can run some tests and decide on the best course of action. I would really prefer to prevent this from becoming another bloated Docker package like Laradock.

@aidan-casey aidan-casey added the enhancement New feature or request label Jul 30, 2020
@aidan-casey
Copy link
Member Author

To the point of Laradock, we are not meant to be the one-stop shop. This package is here for people to modify for their projects.

Given this understanding and the realization that some people don't use Redis for their projects, it may be best to come at this issue by documenting examples for how to set this up in a wiki.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant