Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] make ci green again #1573

Merged
merged 7 commits into from
Feb 20, 2025
Merged

[ci] make ci green again #1573

merged 7 commits into from
Feb 20, 2025

Conversation

agryaznov
Copy link
Contributor

recent PR broke merging ci jobs, let's fix it

@agryaznov agryaznov requested a review from dvc94ch February 19, 2025 14:01
Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason is that multiple ci runs may be happening concurrently on the same machine, so no test/ci-run can use a fixed port number...

@agryaznov
Copy link
Contributor Author

agryaznov commented Feb 19, 2025

current issue

seems to be introduced here

docker build -t chronicle -f ./config/docker/Dockerfile.chronicle-release --build-arg PROFILE=testnet --build-arg FEATURES=testnet,develop .

416.6   error[E0583]: file not found for module `migrations`
416.6     --> /build/runtime/src/lib.rs:88:1
416.6      |
416.6   88 | pub mod migrations;
416.6      | ^^^^^^^^^^^^^^^^^^^
416.6      |
416.6      = help: to create the module `migrations`, create file "/build/runtime/src/migrations.rs" or "/build/runtime/src/migrations/mod.rs"
416.6      = note: if there is a `mod migrations` elsewhere in the crate already, import it with `use crate::...` instead
416.6 
416.6   error[E0433]: failed to resolve: could not find `fix_pool_members` in `migrations`
416.6      --> /build/runtime/src/lib.rs:680:31
416.6       |
416.6   680 | type Migrations = migrations::fix_pool_members::RemoveBuggyPoolMembersMigration<Runtime>;
416.6       |                               ^^^^^^^^^^^^^^^^ could not find `fix_pool_members` in `migrations`

@4meta5 would you please fix it? (for some reason that job wasn't run at the time of your merge, but it definitely was broken at that time)

cc @dvc94ch @penumbra23

@4meta5
Copy link
Contributor

4meta5 commented Feb 19, 2025

@FlorianFranzen is removing the migration to fix it, it is weird because it compiles locally for me and the files and declarations are there

@FlorianFranzen
Copy link
Collaborator

FlorianFranzen commented Feb 20, 2025

Removed any migrations that were no longer needed (including the one bracking chronicle image builds).

Should be ready to go. Will merge it once CI passes.

@FlorianFranzen FlorianFranzen merged commit 5c7fb73 into development Feb 20, 2025
14 of 15 checks passed
@FlorianFranzen FlorianFranzen deleted the ag/ci-green-again branch February 20, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants