-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move e2e tests from a dedicated crate to tests/
at the workspace root
#1566
Conversation
@penumbra23 let's come up with the CI settings reliable enough to be accepted for all the future PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to remove the e2e-tests folder...
@penumbra23 could port mappings break things for other ci jobs? If so we can rm it for now and disable the e2e flow until that's solved |
i guess both chain-2-evm and chain-3-evm is mapped to same port. If we change one to something else it shouldnt be an issue. |
hmm to me it looks like they're mapped to different ones: |
correct my bad. |
For now let's merge this w the new e2e flow off, and without port mappings, until we figure out proper CI setting on the runners for that with @penumbra23 (tbd in a follow-up PR) |
One thing that can be done is export the port but avoid a fixed one:
In this way the OS will assign a free one each time. |
this particular one has been there for a quite a while (was not touched in recent PRs) so I keep it as is here |
@agryaznov This actually added an invalid workflow file still failing CI in some status messages. Just though to let you know as it took me a while to even see where and why the CI was still failing. Nothing to do from your side, I will add a fix #1573. |
A small enhancement regarding integration tests:
Cargo.toml
.tests/
directory, which is neat and in line with general convention for integration tests.