[env] dev to use anvil instead of geth for evm chains #1544

agryaznov · 2025-02-11T19:30:28Z

Closes #1543
Closes #1548

docker-compose.yml

dvc94ch · 2025-02-11T19:32:29Z

Thx!

agryaznov · 2025-02-11T20:14:56Z

Note this also would require some logic change reg. admin account funding, as connector's faucet woudn't work with anvil

2025-02-11T20:08:25.964414Z ERROR rosetta_server::ws::reconnect: rpc request 'eth_sendTransaction' failed: Call(ErrorObject { code: ServerError(-32003), message: "Insufficient funds for gas * price + value", data: None })
Call(
    ErrorObject {
        code: ServerError(
            -32003,
        ),
        message: "Insufficient funds for gas * price + value",
        data: None,
    },
)

dvc94ch · 2025-02-12T09:37:10Z

So this needs some more work:

chain connector should be able to identify when dealing with anvil using the admin_nodeInfo rpc
chain connector should use anvil_setBalance in the faucet

dvc94ch · 2025-02-12T09:50:53Z

never mind, the whole connector codebase is one giant hack. one more hack won't hurt...

agryaznov · 2025-02-12T13:18:41Z

So this needs some more work:

1. chain connector should be able to identify when dealing with anvil using the `admin_nodeInfo` rpc

2. chain connector should use `anvil_setBalance` in the faucet

I think this approach is better than a dirty hack proposed here , with a minor changes:

let's do it in chain connector by passing blockchain: "anvil" to params
Then for anvil we pass private key of default dev account here

gmp/evm/Cargo.toml

haider-rs · 2025-02-14T12:17:30Z

docker-compose.yml

-    - '--verbosity=4'
+    - 'anvil -b 2 --steps-tracing --base-fee 0'
+    environment:
+        ANVIL_IP_ADDR: '0.0.0.0'


which port does it export the rpc to host machine for querying?

none. but you can query it with docker compose run tc-cli debug-transaction NETWORK_ID TX_HASH

gmp/evm/src/lib.rs

dvc94ch

cc @agryaznov

dvc94ch · 2025-02-17T11:25:38Z

analog-gmp/src/interfaces/IGmpReceiver.sol

@@ -17,7 +17,7 @@ interface IGmpReceiver {
     * @param payload The message payload with no specified format
     * @return 32 byte result which will be stored together with GMP message
     */
-    function onGmpReceived(bytes32 id, uint128 network, bytes32 source, bytes calldata payload)
+    function onGmpReceived(bytes32 id, uint128 network, bytes32 source, uint64 nonce, bytes calldata payload)


@agryaznov here's the change causing the issue

dvc94ch · 2025-02-17T11:26:51Z

analog-gmp/test/utils/GmpProxy.sol

-    function onGmpReceived(bytes32 id, uint128, bytes32, bytes calldata payload) external payable returns (bytes32) {
-        // For testing purpose
-        // we keep the original struct in payload so we dont depend on OnGmpReceived call since it doesnt provide everything.
-        (GmpMessage memory message) = abi.decode(payload, (GmpMessage));
-        message.data = payload;
-
+    function onGmpReceived(bytes32 id, uint128 srcNetwork, bytes32 src, uint64 nonce, bytes calldata payload) external payable returns (bytes32) {
+        // when estimating gas an insane amount of gas is provided
+        uint256 gasLimit = gasleft();
+        // this is the constant added to gasLimit
+        unchecked { console.log(300_000 - gasLimit); }
+        uint64 msgGasLimit;
+        unchecked { msgGasLimit = uint64(gasLimit + 579); }
+        GmpMessage memory message = GmpMessage({
+            source: src,
+            srcNetwork: uint16(srcNetwork),
+            dest: address(this),
+            destNetwork: NETWORK_ID,
+            gasLimit: msgGasLimit,
+            nonce: nonce,
+            data: payload
+        });


here's the reason for the change.

nonce is determined by gateway

this was worked around by guessing the nonce before submitting the message and then encoding the GmpMessage struct in the payload.

dvc94ch · 2025-02-17T11:28:02Z

gmp/evm/src/lib.rs

+	async fn estimate_message_gas_limit(
+		&self,
+		contract: Address,
+		src_network: NetworkId,
+		src: Address,
+		payload: Vec<u8>,
+	) -> Result<u128> {
+		let call = sol::IGmpReceiver::onGmpReceivedCall {
+			id: [0; 32].into(),
+			network: src_network.into(),
+			source: src.into(),
+			nonce: 0,
+			payload: payload.into(),
+		};
+		let gas_limit = self
+			.wallet
+			.eth_send_call_estimate_gas(a_addr(contract).into(), call.abi_encode(), 0)
+			.await?;
+		Ok(gas_limit)
+	}


we also guessed the gas_limit, which was hard coded to 300000 gas. this caused messages to be 5x overpriced

dvc94ch · 2025-02-17T11:29:08Z

gmp/evm/src/lib.rs

+	async fn estimate_message_cost(
+		&self,
+		gateway: Address,
+		dest_network: NetworkId,
+		gas_limit: u128,
+		payload: Vec<u8>,
+	) -> Result<u128> {
+		let msg = sol::GmpMessage {
+			source: [0; 32].into(),
+			srcNetwork: 0,
+			dest: [0; 20].into(),
+			destNetwork: 0,
+			gasLimit: 0,
+			nonce: 0,
+			data: payload.into(),
+		};
 		let call = sol::Gateway::estimateMessageCostCall {
-			networkid: dest,
-			messageSize: U256::from(bytes.len()),
+			networkid: dest_network,
+			// abi_encoded_size returns the size without the 4 byte selector
+			messageSize: U256::from(msg.abi_encoded_size() + 4),
 			gasLimit: U256::from(gas_limit),


this message used to be called internally in submit message, but we want to estimate the final cost before submitting the message

dvc94ch · 2025-02-17T11:34:40Z

tc-cli/src/main.rs

+			let gas_limit = tc
+				.estimate_message_gas_limit(dest, dest_addr, src, src_addr, payload.clone())
+				.await?;
+			let gas_cost = tc.estimate_message_cost(src, dest, gas_limit, payload.clone()).await?;
+			let msg_id = tc
+				.send_message(src, src_addr, dest, dest_addr, gas_limit, gas_cost, payload.clone())
+				.await?;


see here for how its used

dvc94ch · 2025-02-17T11:34:57Z

tc-cli/src/main.rs

+		Command::EstimateMessageGasLimit {
+			dest_network,
+			dest_addr,
+			src_network,
+			src_addr,
+			payload,
+		} => {
+			let src_addr = tc.parse_address(Some(src_network), &src_addr)?;
+			let dest_addr = tc.parse_address(Some(dest_network), &dest_addr)?;
+			let payload = hex::decode(payload)?;
+			let gas_limit = tc
+				.estimate_message_gas_limit(dest_network, dest_addr, src_network, src_addr, payload)
+				.await?;
+			tc.println(None, gas_limit.to_string()).await?;
+		},
+		Command::EstimateMessageGasCost {
+			src_network,
+			dest_network,
+			gas_limit,
+			payload,
+		} => {
+			let payload = hex::decode(payload)?;
+			let gas_cost =
+				tc.estimate_message_cost(src_network, dest_network, gas_limit, payload).await?;
+			tc.println(None, gas_cost.to_string()).await?;
+		},


and the new utilities we have in tc-cli

dev to use anvil instead of geth for evm chains

a5c3020

agryaznov commented Feb 11, 2025

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

agryaznov marked this pull request as ready for review February 11, 2025 19:31

agryaznov requested a review from dvc94ch February 11, 2025 19:31

dvc94ch approved these changes Feb 11, 2025

View reviewed changes

fix

74735cd

agryaznov marked this pull request as draft February 11, 2025 20:17

Refactor faucet.

3ce9f34

dvc94ch added 3 commits February 12, 2025 11:01

Use reexported crates.

0cb4690

Update configs.

f3be40e

Refactor faucet.

554e097

dvc94ch approved these changes Feb 12, 2025

View reviewed changes

Fix clippy.

a6ec4ff

dvc94ch marked this pull request as ready for review February 12, 2025 11:32

Enable tracing.

3c654f3

agryaznov commented Feb 12, 2025

View reviewed changes

gmp/evm/Cargo.toml Outdated Show resolved Hide resolved

dvc94ch added 9 commits February 12, 2025 15:03

Use relative paths.

6fc8ca9

Fix tests.

f435efd

Add debug-transaction command.

fbe9f95

Implement debug_transaction.

a379046

Cleanup gmp-evm txs.

ef17330

More cleanup.

b10c591

Get it working.

75cde96

Add source debugging.

61dc238

Nits logs.

e1955c1

dvc94ch added 3 commits February 13, 2025 18:22

Estimate gas limit.

527f0cc

Update tc-cli.

5e2917a

Fix clippy.

17a8c45

dvc94ch force-pushed the ag/anvil branch from fae6adf to 17a8c45 Compare February 13, 2025 18:03

dvc94ch added 6 commits February 13, 2025 19:16

Fix review comments.

d54439f

Add nonce to onGmpReceived.

e64fdd7

Fix GmpProxy.

cb1d719

Update tc-cli.

226910d

Fix startup issue.

4c61d0c

Fix some assembly.

70c2c7e

haider-rs reviewed Feb 14, 2025

View reviewed changes

haider-rs approved these changes Feb 14, 2025

View reviewed changes

gmp/evm/src/lib.rs Show resolved Hide resolved

dvc94ch merged commit f52fff2 into development Feb 14, 2025
13 of 15 checks passed

dvc94ch deleted the ag/anvil branch February 14, 2025 17:24

dvc94ch reviewed Feb 17, 2025

View reviewed changes

agryaznov mentioned this pull request Feb 17, 2025

port timechain#1544 to here Analog-Labs/analog-gmp#45

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[env] dev to use anvil instead of geth for evm chains #1544

[env] dev to use anvil instead of geth for evm chains #1544

agryaznov commented Feb 11, 2025 •

edited by dvc94ch

Loading

dvc94ch commented Feb 11, 2025

agryaznov commented Feb 11, 2025

dvc94ch commented Feb 12, 2025

dvc94ch commented Feb 12, 2025

agryaznov commented Feb 12, 2025

haider-rs Feb 14, 2025

dvc94ch Feb 14, 2025

dvc94ch left a comment

dvc94ch Feb 17, 2025

dvc94ch Feb 17, 2025

dvc94ch Feb 17, 2025

dvc94ch Feb 17, 2025

dvc94ch Feb 17, 2025

dvc94ch Feb 17, 2025

[env] dev to use anvil instead of geth for evm chains #1544

[env] dev to use anvil instead of geth for evm chains #1544

Conversation

agryaznov commented Feb 11, 2025 • edited by dvc94ch Loading

dvc94ch commented Feb 11, 2025

agryaznov commented Feb 11, 2025

dvc94ch commented Feb 12, 2025

dvc94ch commented Feb 12, 2025

agryaznov commented Feb 12, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dvc94ch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agryaznov commented Feb 11, 2025 •

edited by dvc94ch

Loading