primitives: properly integrate with ss58 registry #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FlorianFranzen So this initializes the clients to always use the proper ss58 format based on the metadata I suppose? No need to manually set it anymore? |
|
It sets some of the internal defaults and the IDs come from the official (and patched) registry. |
dvc94ch
approved these changes
Feb 8, 2025
4meta5
approved these changes
Feb 9, 2025
|
Will merge it as soon as I can get a clean integration test run. |
FlorianFranzen
force-pushed
the
florian/ss58-default
branch
from
3a5ad23 to
d06d0f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that the correct ss58 prefix is used at all times by properly configuring sp_core where needed.