Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking fixes #1219

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Oct 18, 2024

Changes

Manual => Derived Weights:

  • elections::try_elect_shard
  • shards::do_dkg_timeout
  • members::do_heartbeat_timeouts

No longer need to return Weights:

  • shards::member_offline
  • elections::member_offline
  • members::member_offline

Verify checks added:

  • shards::do_dkg_timeout
  • members::do_heartbeat_timeouts
  • elections::try_elect_shard
  • tasks::prepare_batches
  • tasks::schedule_tasks

Verify checks failed => new worst-case:

  • elections::try_elect_shard
  • tasks::schedule_tasks
  • tasks::prepare_batches
  • tasks::submit_task_result

Before merging:

  • re-run benchmarks => update weights

Upper bounds:

  • MaxTasksPerBlock = 50 (max measured by runtime test was 81)
  • MaxBatchesPerBlock = 10 (max measured by runtime test was 41)
  • shards::Config::MaxTimeoutsPerBlock = 100
  • members::Config::MaxTimeoutsPerBlock = 100

Follow Ups

@4meta5 4meta5 added this to the Milestone Q4 2024 milestone Oct 18, 2024
@4meta5 4meta5 self-assigned this Oct 18, 2024
@4meta5 4meta5 changed the title Manual => Benchmark-Derived Weight Functions Fix pallet benchmarking Oct 21, 2024
@4meta5 4meta5 changed the title Fix pallet benchmarking Fix pallet benchmarks Oct 21, 2024
@4meta5 4meta5 changed the title Fix pallet benchmarks Benchmarking pallet fixes Oct 21, 2024
@4meta5 4meta5 changed the title Benchmarking pallet fixes Benchmarking fixes Oct 21, 2024
@4meta5 4meta5 added !ci-benchmark Benchmark and commit new weights ready-for-review PR author(s) done with coding and reviewer[s] can start and removed WIP labels Oct 22, 2024
@4meta5 4meta5 requested a review from dvc94ch October 22, 2024 15:21
@4meta5 4meta5 requested a review from haider-rs October 22, 2024 15:21
Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @4meta5

@dvc94ch
Copy link
Collaborator

dvc94ch commented Oct 23, 2024

ci is failing do to some assertions being triggered...

@4meta5
Copy link
Contributor Author

4meta5 commented Oct 23, 2024

ci is failing do to some assertions being triggered...

yes currently debugging the failed assertions, progress tracked in PR description

will not merge until weights are updated and CI is green

@4meta5 4meta5 added status: confirmed ready-for-review PR author(s) done with coding and reviewer[s] can start and removed ready-for-review PR author(s) done with coding and reviewer[s] can start status: confirmed labels Oct 23, 2024
@4meta5 4meta5 removed the !ci-benchmark Benchmark and commit new weights label Oct 24, 2024
@4meta5 4meta5 merged commit 7985f8c into development Oct 24, 2024
11 checks passed
@4meta5 4meta5 deleted the amar-replace-manual-weight-accounting-with-benchmark-derived-functions branch October 24, 2024 02:56
@4meta5 4meta5 mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: critical ready-for-review PR author(s) done with coding and reviewer[s] can start
Projects
None yet
2 participants