-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking fixes #1219
Merged
4meta5
merged 26 commits into
development
from
amar-replace-manual-weight-accounting-with-benchmark-derived-functions
Oct 24, 2024
Merged
Benchmarking fixes #1219
4meta5
merged 26 commits into
development
from
amar-replace-manual-weight-accounting-with-benchmark-derived-functions
Oct 24, 2024
+728
−389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-with-benchmark-derived-functions
…th one manually derived benchmark instead
…-with-benchmark-derived-functions
dvc94ch
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @4meta5
ci is failing do to some assertions being triggered... |
yes currently debugging the failed assertions, progress tracked in PR description will not merge until weights are updated and CI is green |
…-with-benchmark-derived-functions
4meta5
commented
Oct 23, 2024
4meta5
commented
Oct 24, 2024
no longer needed in benchmarking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
priority: critical
ready-for-review
PR author(s) done with coding and reviewer[s] can start
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Manual => Derived Weights:
No longer need to return Weights:
Verify checks added:
Verify checks failed => new worst-case:
Before merging:
Upper bounds:
Follow Ups