Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound extrinsic inputs #1185

Merged
merged 32 commits into from
Oct 18, 2024
Merged

Bound extrinsic inputs #1185

merged 32 commits into from
Oct 18, 2024

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Oct 7, 2024

Closes #662

Extrinsics for which unbounded inputs were bounded in this PR:

  • tasks (submit_result)
  • shards (commit)
  • network (register_network)
  • dmail (send_email)

TODOs:

Follow-ups:

@4meta5 4meta5 added this to the Milestone Q4 2024 milestone Oct 7, 2024
@4meta5 4meta5 self-assigned this Oct 7, 2024
@4meta5 4meta5 mentioned this pull request Oct 7, 2024
5 tasks
@haider-rs
Copy link
Contributor

Hi Thanks for taking tihs on! One update that dmail pallet needed regarding bounding data is that their to and path field will always be of 64 length. So we can bound it to that fixed length.

@4meta5
Copy link
Contributor Author

4meta5 commented Oct 8, 2024

One update that dmail pallet needed regarding bounding data is that their to and path field will always be of 64 length. So we can bound it to that fixed length.

Thanks, done in f6279ca

@4meta5 4meta5 added security bug Something isn't working !ci-benchmark Benchmark and commit new weights and removed WIP labels Oct 8, 2024
Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks fine

@4meta5 4meta5 added the ready-for-review PR author(s) done with coding and reviewer[s] can start label Oct 11, 2024
@4meta5 4meta5 requested a review from haider-rs October 11, 2024 03:17
@4meta5
Copy link
Contributor Author

4meta5 commented Oct 15, 2024

ok all the type aliases need to be changed to wrapper structs because of subxt metadata constraints according to david. #1212

@4meta5 4meta5 mentioned this pull request Oct 15, 2024
7 tasks
@4meta5 4meta5 requested a review from dvc94ch October 17, 2024 17:33
@4meta5 4meta5 added the !ci-benchmark Benchmark and commit new weights label Oct 17, 2024
@4meta5

This comment has been minimized.

Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @4meta5 !

@4meta5

This comment has been minimized.

@dvc94ch

This comment has been minimized.

@4meta5 4meta5 removed the !ci-benchmark Benchmark and commit new weights label Oct 17, 2024
@4meta5 4meta5 added status: confirmed and removed ready-for-review PR author(s) done with coding and reviewer[s] can start labels Oct 17, 2024
@4meta5 4meta5 merged commit 0558019 into development Oct 18, 2024
11 checks passed
@4meta5 4meta5 deleted the amar-bound-tx-inputs-postv2 branch October 18, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bound all extrinsic inputs
3 participants