New timegraph tokenomics #1161
Merged
New timegraph tokenomics #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: TaniaSaleem <[email protected]> Co-authored-by: Tania Saleem <[email protected]> Co-authored-by: Florian Franzen <[email protected]>
ana-junius
requested review from
dvc94ch,
FlorianFranzen,
Lohann,
4meta5,
haider-rs and
taniasaleem
ana-junius
added
the
ready-for-review
4meta5
reviewed
Oct 15, 2024
pallets/timegraph/src/lib.rs
Outdated
Comment on lines
89
to
105
| /// Default value from runtime configuration | ||
| #[pallet::type_value] | ||
| pub fn DefaultTimegraphAccount<T: Config>() -> T::AccountId { | ||
| T::InitialTimegraphAccount::get() | ||
| } | ||
|
|
||
| /// Default value from runtime configuration | ||
| #[pallet::type_value] | ||
| pub fn DefaultRewardPoolAccount<T: Config>() -> T::AccountId { | ||
| T::InitialRewardPoolAccount::get() | ||
| } | ||
|
|
||
| /// Default value from runtime configuration | ||
| #[pallet::type_value] | ||
| pub fn DefaultThreshold<T: Config>() -> BalanceOf<T> { | ||
| T::InitialThreshold::get() | ||
| } |
There was a problem hiding this comment.
I don't really understand the need for these additional types. You can just use constants directly as the default value parameter in the storage map
There was a problem hiding this comment.
To make the tokenomics of timegraph works, we need all these values are set, not empty. For default value, we will set it as different values in different env like testnet/devnet/mainnet.
4meta5
reviewed
Oct 15, 2024
pallets/timegraph/src/lib.rs
Outdated
| #[pallet::storage] | ||
| #[pallet::getter(fn timegraph_account)] | ||
| pub type TimegraphAccount<T: Config> = | ||
| StorageValue<_, T::AccountId, ValueQuery, DefaultTimegraphAccount<T>>; |
There was a problem hiding this comment.
Suggested change
| StorageValue<_, T::AccountId, ValueQuery, DefaultTimegraphAccount<T>>; | |
| StorageValue<_, T::AccountId, ValueQuery, T::InitialTimegraphAccount>; |
like this
4meta5
reviewed
Oct 15, 2024
4meta5
approved these changes
Oct 15, 2024
|
@foreseon any comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR implements the new timegraph tokenomics feature. based on the proposal of security. It will fix #1193