-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: fix missing migrations #1008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f18f7f
to
8779e58
Compare
4meta5
reviewed
Jul 15, 2024
4meta5
reviewed
Jul 15, 2024
@4meta5 This is what happens if I enable all state to be checked: Undecodable Values in `Shards::ShardState`
EDIT: Fixed in additional commit by avoiding index shift. |
4meta5
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority: critical
ready-for-review
PR author(s) done with coding and reviewer[s] can start
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest update failed due to some missing migrations. These PR fixes this and add a new CI to check for them in the future.
Type of change
Please delete options that are not relevant.
Tests
I ran a full try runtime test locally, it still fails for some missing migrations in the shard pallet.
Code review prechecks: