Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): runtime artifact name separation #1006

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

penumbra23
Copy link
Contributor

Description

Generate different name for different runtime artifact while building with srtool

Fixes

Broken srtool build when building multiple rntimes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

WIP: better to include a custom name instead of features
@penumbra23 penumbra23 merged commit 8dde8b0 into development Jul 12, 2024
4 checks passed
@FlorianFranzen FlorianFranzen deleted the fix/runtime-artifact-names branch July 15, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant