Fix broken benchmark tests #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haider-rs
force-pushed
the
fix-broken-benches
branch
from
1fd00e1 to
89cf8ef
Compare
haider-rs
force-pushed
the
fix-broken-benches
branch
from
385c5bf to
7ebd55d
Compare
|
can we add ci-benchmark and push an empty commit (ie into development) to trigger generating new weights based on these changes as well? this would also confirm that running the benchmarks to generate weights works when it is run through the CI (I know you verified it runs manually but could be different) |
4meta5
approved these changes
Jul 11, 2024
|
rerunning. the failure was due to cancelling the benchmarking after almost 6h. how long does benchmarking usually take? 6h seems like a lot... cc @penumbra23 |
Closed
FlorianFranzen
approved these changes
Jul 16, 2024
|
Not sure what the hold-up is here. Will merge it for now as this block my further work. @dvc94ch runtime-benchmarks will need to be addressed separately. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes outdated/broken benchmark tests.
Fixes # (issue)
#997
Type of change
Code review prechecks: