Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tc-cli] handle admin acc funding error better #1607

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

agryaznov
Copy link
Contributor

@agryaznov agryaznov commented Feb 26, 2025

fixes #1604

currently tc-cli deploy fails when !admin_funds.is_zero() in config and the network doesn't support faucet

Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the right way to fix this is setting admin_funds: 0 for that network. Then the faucet isn't used...

@dvc94ch
Copy link
Collaborator

dvc94ch commented Feb 26, 2025

@penumbra23 can you try setting the admin_funds to 0 for unsupported networks or when the account needs prefunding and see if that resolves the issue?

@dvc94ch
Copy link
Collaborator

dvc94ch commented Feb 26, 2025

What I don't get is why we're trying to use faucet if network is prefunded or where the funds of the admin account disappeared

@dvc94ch
Copy link
Collaborator

dvc94ch commented Feb 26, 2025

Basically what it's saying is you requested x amount of admin funds but your account is below that and we couldn't resolve the issue for you automatically in a not very user-friendly way

@agryaznov
Copy link
Contributor Author

agryaznov commented Feb 26, 2025

well probably you're right; this PR just patches it to work as before coz @penumbra23 said he's blocked with this issue.. if setting admin_funds solves it, then np I guess (not a big fan of hard-coding those network ids either)

@dvc94ch
Copy link
Collaborator

dvc94ch commented Feb 26, 2025

Would still be great to have tc-cli provide a more descriptive error message...

@agryaznov agryaznov changed the title [bugfix] patch evm backend faucet (not to panic on unsupported networks) [tc-cli] handle admin acc funding error better Feb 26, 2025
@agryaznov agryaznov marked this pull request as draft February 26, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tc-cli fails with 'no accounts found' message
2 participants