You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noticed during #1185 that pallet elections uses manual weight accounting in a few places. All manual weight accounting should be replaced with benchmark-derived functions.
elections::try_elect_shard
elections::member_offline
shards::member_offline
shards::on_initialize
check ALL other pallets for any other manual weight accounting worth updating to the benchmark-derived function
The benchmark-derived weight function approach is preferred to manual accounting for 2 reasons:
easier to maintain because the code does not have to updated manually with changes
more accurate because it accounts for more than just the unit cost of reads/writes
The text was updated successfully, but these errors were encountered:
Increased priority and started immediately because I want weight accounting to be as accurate as possible to decrease the likelihood that inaccurate weights are contributing to inconsistent block times (which is sometimes the case when inaccuracy underestimates actual computation).
Noticed during #1185 that pallet elections uses manual weight accounting in a few places. All manual weight accounting should be replaced with benchmark-derived functions.
The benchmark-derived weight function approach is preferred to manual accounting for 2 reasons:
The text was updated successfully, but these errors were encountered: