Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self audit of all custom pallets #1104

Closed
7 tasks done
4meta5 opened this issue Sep 4, 2024 · 3 comments
Closed
7 tasks done

Self audit of all custom pallets #1104

4meta5 opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working priority: high security

Comments

@4meta5
Copy link
Contributor

4meta5 commented Sep 4, 2024

Tracking work requested by @0x1100010010 as a meta issue

This issue serves to collect, prioritize, and close ALL known && unknown issues for ALL custom pallets:

  • tasks
  • shards
  • election
  • members
  • governance
  • networks
  • timegraph

Check off a pallet listed above iff both of these conditions are met:

  1. the issue has been created with a comprehensive listing of all known && unknown issues and optimizations for the pallet
  2. the issue has been closed by a PR or PRs fixing all known && unknown issues and optimizations
@4meta5 4meta5 self-assigned this Sep 4, 2024
@4meta5 4meta5 added bug Something isn't working epic security labels Sep 4, 2024
@4meta5
Copy link
Contributor Author

4meta5 commented Sep 16, 2024

List of related issues discovered during audit before opening separate issue for each with more info:

time graph

  • value add/purpose of custom timegraph extrinsics deposit and withdraw vs using pallet-balances::transfer and all of its storage counters
  • replace timegraph ZeroAmount error with changing the extrinsic input to be NonZeroU32

@4meta5
Copy link
Contributor Author

4meta5 commented Oct 3, 2024

This issue has been iced during the V2 refactor. It is no longer in progress and need to revisited after that refactor.

@4meta5
Copy link
Contributor Author

4meta5 commented Oct 22, 2024

@4meta5 4meta5 closed this as completed Oct 22, 2024
@4meta5 4meta5 added this to the Milestone Q4 2024 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high security
Projects
None yet
Development

No branches or pull requests

3 participants