Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove repeated code #258

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Conversation

ManojJiSharma
Copy link
Contributor

Description

Creating crate for same code in different crates to put shared testing logic.

#253 (comment)

@ManojJiSharma ManojJiSharma linked an issue Sep 20, 2024 that may be closed by this pull request
@ManojJiSharma ManojJiSharma self-assigned this Sep 20, 2024
@ManojJiSharma ManojJiSharma marked this pull request as ready for review September 20, 2024 12:30
Comment on lines +1 to +6
use std::future::Future;

/// Run the test in another thread while sending txs
/// # Panic
/// Panics if the future panics
pub async fn run_test<Fut: Future<Output = ()> + Send + 'static>(future: Fut) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tokio as dependency, NICE! great job @ManojJiSharma !!

@ManojJiSharma ManojJiSharma merged commit 12bc709 into master Sep 23, 2024
10 checks passed
@ManojJiSharma ManojJiSharma deleted the 257-remove-repeated-code-from-chains branch September 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove repeated code from chains
2 participants