Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic batching #36

Merged
merged 20 commits into from
Jan 6, 2025
Merged

Basic batching #36

merged 20 commits into from
Jan 6, 2025

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Dec 26, 2024 •
edited
Loading

  • Add support for batching heterogeneous messages
  • Add gasCost to GmpCreated event.
  • Compute the batch signing hash the same way as timechain (except I fixed some issues regarding hashing operations).
  • Include the parity bit and Command to batch signing hash.
  • Remove a lot of inline assembly to improve code readability and maintainability.
  • Add a check to guarantee the contract is within EIP-170 Contract size limit.

@haider-rs
Copy link
Contributor

haider-rs commented Dec 29, 2024 •
edited
Loading

Added some fixes here due to which i was blocked:
#38

@Lohann
Copy link
Collaborator Author

Lohann commented Dec 30, 2024 •
edited
Loading

Missing:

  • Add the gasCost field to GmpCreated event
  • Include the DomainSeparator when hashing the BatchID

@Lohann Lohann marked this pull request as ready for review January 5, 2025 20:37
@Lohann Lohann requested review from haider-rs and dvc94ch January 5, 2025 20:37
@Lohann Lohann merged commit 97386e7 into main Jan 6, 2025
1 check passed
@Lohann Lohann deleted the feature/batch-execute branch January 6, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haider-rs haider-rs Awaiting requested review from haider-rs

@dvc94ch dvc94ch Awaiting requested review from dvc94ch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lohann @haider-rs