From 645504abdbd86c1fd094e3cec806e22e2e3df6b7 Mon Sep 17 00:00:00 2001 From: Remy van der Wereld Date: Tue, 8 Oct 2024 13:59:56 +0200 Subject: [PATCH] 127818 bugfix white screen exhaustive-deps --- .../components/pages/create/CreateItineraryPage.tsx | 3 ++- .../components/pages/list/ListItinerariesPage.tsx | 7 +++++-- src/app/features/shared/components/pages/HomePage.tsx | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/app/features/itineraries/components/pages/create/CreateItineraryPage.tsx b/src/app/features/itineraries/components/pages/create/CreateItineraryPage.tsx index 6d5c81bdc..c002713c8 100644 --- a/src/app/features/itineraries/components/pages/create/CreateItineraryPage.tsx +++ b/src/app/features/itineraries/components/pages/create/CreateItineraryPage.tsx @@ -26,7 +26,8 @@ const CreateItineraryPage: React.FC = () => { if (redirectToExistingItinerary) { redirectToCorrectItineraryPage(data?.itineraries) } - }, [redirectToExistingItinerary, data, redirectToCorrectItineraryPage]) + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [redirectToExistingItinerary, data]) if (!teamSettings) { return null diff --git a/src/app/features/itineraries/components/pages/list/ListItinerariesPage.tsx b/src/app/features/itineraries/components/pages/list/ListItinerariesPage.tsx index d1b16c226..2c1bf3fbd 100644 --- a/src/app/features/itineraries/components/pages/list/ListItinerariesPage.tsx +++ b/src/app/features/itineraries/components/pages/list/ListItinerariesPage.tsx @@ -8,6 +8,7 @@ import Spacing from "app/features/shared/components/atoms/Spacing/Spacing" import DefaultLayout from "app/features/shared/components/layouts/DefaultLayout/DefaultLayout" import to from "app/features/shared/routing/to" import { useRedirectToCorrectItineraryPage } from "app/features/itineraries/utils/useRedirectToCorrectItineraryPage" +import CenteredSpinner from "app/features/shared/components/atoms/CenteredSpinner/CenteredSpinner" const Li = styled.li` margin-bottom: ${ themeSpacing(4) }; @@ -19,15 +20,17 @@ const TeamName = styled.strong` ` const ListItinerariesPage: React.FC = () => { - const { data } = useItineraries() + const { data, isBusy } = useItineraries() const { redirectToCorrectItineraryPage } = useRedirectToCorrectItineraryPage() useEffect(() => { redirectToCorrectItineraryPage(data?.itineraries) - }, [data, redirectToCorrectItineraryPage]) + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [data]) return ( + {isBusy && } { data && data.itineraries.length > 0 && ( <> diff --git a/src/app/features/shared/components/pages/HomePage.tsx b/src/app/features/shared/components/pages/HomePage.tsx index 4d061de5b..d97cf959e 100644 --- a/src/app/features/shared/components/pages/HomePage.tsx +++ b/src/app/features/shared/components/pages/HomePage.tsx @@ -9,7 +9,8 @@ const HomePage: React.FC = () => { useEffect(() => { redirectToCorrectItineraryPage(data?.itineraries) - }, [data, redirectToCorrectItineraryPage]) + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [data]) const explanation = errors.length > 0 ? "Sorry, de pagina kan niet worden geladen. Probeer het later opnieuw." : "Even geduld alstublieft…"