Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Misc UI issues due to resizable and collapsible panel #5965

Open
1 task done
xingyaoww opened this issue Jan 2, 2025 · 2 comments · May be fixed by #5966
Open
1 task done

[Bug]: Misc UI issues due to resizable and collapsible panel #5965

xingyaoww opened this issue Jan 2, 2025 · 2 comments · May be fixed by #5966
Labels
bug Something isn't working fix-me-experimental frontend Related to frontend Nit

Comments

@xingyaoww
Copy link
Collaborator

xingyaoww commented Jan 2, 2025

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

After PR #5926, we have a resizable and collapsible panel layout.

However, here are a few issues here:

  1. The default layout doesn't look good (e.g., the chat window is a little too wide when with a smaller screen, the bottom right terminal is a bit too tall)

image

We should revert to our original ratio (maybe 30% of the width should be the chat box, and the terminal is also about 30% of the height) by default.
Then, the user can choose to adjust to whatever place they like.

  1. Resizable / Collapsible causes issues if we push them too far

For example, If we resize the chat window too far:
image

Resize terminal too far, the workspace window will get resized with incorrect asepct ratio.

image

And if we resize to the right too far, the window will go outside of the browser.

image

For this issue, I think we should just enforce an appropriate min-width / height for each of these components in the UI.
a

OpenHands Installation

app.all-hands.dev

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

@xingyaoww xingyaoww added the bug Something isn't working label Jan 2, 2025
@xingyaoww xingyaoww changed the title [Bug]: Misc UI issues [Bug]: Misc UI issues due to resizable and collapsible panel Jan 2, 2025
@openhands-agent
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@openhands-agent
Copy link
Contributor

A potential fix has been generated and a draft PR #5966 has been created. Please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-me-experimental frontend Related to frontend Nit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants