Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile keyword does not exist in the new versions of Gradle #305

Open
EsaNuurtamo opened this issue May 23, 2023 · 1 comment
Open

Compile keyword does not exist in the new versions of Gradle #305

EsaNuurtamo opened this issue May 23, 2023 · 1 comment

Comments

@EsaNuurtamo
Copy link

EsaNuurtamo commented May 23, 2023

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

In newer version of gradle that is used in new react-native versions function compile name has been changed to implementation

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-i18n/android/build.gradle b/node_modules/react-native-i18n/android/build.gradle
index 2614c62..746b873 100644
--- a/node_modules/react-native-i18n/android/build.gradle
+++ b/node_modules/react-native-i18n/android/build.gradle
@@ -22,5 +22,5 @@ android {
 }
 
 dependencies {
-  compile "com.facebook.react:react-native:+" // From node_modules
+  implementation "com.facebook.react:react-native:+" // From node_modules
 }

This issue body was partially generated by patch-package.

@HodeiG
Copy link

HodeiG commented Jun 5, 2023

Does the main README also need to be updated?

In file ./android/app/build.gradle, I had to modify this:

dependencies {
    // ...
    compile project(':react-native-i18n')
}

To this:

dependencies {
    // ...
    implementation project(':react-native-i18n')
}

p.d.: I am new to react-native development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants