Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicking and dimming (PWM) #4

Open
Huakus opened this issue May 21, 2016 · 6 comments
Open

Flicking and dimming (PWM) #4

Huakus opened this issue May 21, 2016 · 6 comments

Comments

@Huakus
Copy link

Huakus commented May 21, 2016

Hi Alex! Tanks very much for your work, it was a huge help for me.
I made some "improvements" to the library, that includes the posibility to asincronously flick each X miliseconds for an undefined period of time; and dimm the led, asincronously as well, for an undefined period of time.
wp_20160521_01_42_03_pro
The problem is that I never used GitHub, and I got a little bit lost in the process of forking and requesting a pull. So, I don't know if I did it right or not, sorry if I made some mistake.
In any case, I can give you the code, so you can check it.
Let me know!

Thanks again! =)

@AlexSartori
Copy link
Owner

That is great! Yes you can email me your code or check on-line how to make a pull request and I'll be very happy to add your contribution 😃

@Huakus
Copy link
Author

Huakus commented May 28, 2016

Alex! Sorry for the delay. Definitely I have no idea how to create a new branch and the proper pll request, I attach the files here: RaspberryGPIOManager.zip
I also add a link to OneDrive with the code.

It's super simple, but let me know if you like it or not

@Huakus
Copy link
Author

Huakus commented May 28, 2016

The methods I added to the projects are "async" methods. Digging more deeply, I was able to see that, for a CPU-only process like this ones, is a little more "clean" to use " Parallel.For", not "Async" methods.
If you like, feel free to modify it in any way. =)

@AlexSartori
Copy link
Owner

Sorry to tell you but your files are identical to mine 😯

@Huakus
Copy link
Author

Huakus commented Jun 1, 2016

You are right! I'm very sorry!

HERE I drop the correct project.

Sorry for the inconveniences.

@AlexSartori
Copy link
Owner

Grand, your changes are pushed to the main repo 😉
Thanks again for your contribution, it's awesome to receive improvements by users of my work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants