-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker examples #3
base: main
Are you sure you want to change the base?
Conversation
Docker command and docker-compose examples to get it work on docker systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I have some little nitpick here and there
cloudflare-ddns: | ||
image: ghcr.io/akarys42/cloudflare-ddns-docker | ||
container_name: ddns_client | ||
enviroment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should instead be loading a .env
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested using env_file: .env
instead of environment:
and works as intended. Just add a .env
file to the same directory.
ref: env_file | Compose specification | Docker Documentation
-e CF_DDNS_TOKEN="${token}" \ | ||
-d ghcr.io/akarys42/cloudflare-ddns-docker | ||
``` | ||
(replacing ${token} by your Cloudflare DNS Edit Permission Token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use $TOKEN
instead as it is the syntax for a shell variable
@@ -35,6 +35,38 @@ docker pull ghcr.io/akarys42/cloudflare-ddns-docker | |||
|
|||
There are no special requirements when building this container! Simply use `docker build` in this folder. | |||
|
|||
#### For docker command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### For docker command | |
### Running on Docker |
``` | ||
(replacing ${token} by your Cloudflare DNS Edit Permission Token) | ||
|
||
#### For docker-compose users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### For docker-compose users | |
### Running on Docker-compose |
I can't, man. I have other things (more important) to do regards
|
All good, I will take care of it. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloudflare-ddns: | ||
image: ghcr.io/akarys42/cloudflare-ddns-docker | ||
container_name: ddns_client | ||
enviroment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: enviroment
should be environment
cloudflare-ddns: | ||
image: ghcr.io/akarys42/cloudflare-ddns-docker | ||
container_name: ddns_client | ||
enviroment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: enviroment
should be environment
cloudflare-ddns: | ||
image: ghcr.io/akarys42/cloudflare-ddns-docker | ||
container_name: ddns_client | ||
enviroment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested using env_file: .env
instead of environment:
and works as intended. Just add a .env
file to the same directory.
ref: env_file | Compose specification | Docker Documentation
README.md