Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup should fail (or at minimum log) on necessary configuration #566

Open
richard-keebler opened this issue Oct 24, 2023 · 2 comments
Open
Assignees
Labels
improvement issues related to product improvement

Comments

@richard-keebler
Copy link

I need the following improvement

The aidbox application starts up fine, even when missing necessary configuration. A common pattern in applications that have required or necessary configuration is to either inform via logs of a missing configuration or fail to start.

The expected benefit

Knowing what to configure.

@richard-keebler richard-keebler added the improvement issues related to product improvement label Oct 24, 2023
@ddegr
Copy link

ddegr commented Oct 24, 2023

Did you see the list of required ENVs here and the optional ones here.

Hope it helped

@richard-keebler
Copy link
Author

richard-keebler commented Oct 24, 2023

Sure, but as I said above, documenting is not enough. The application needs to handle these. For example, if it was missing the admin password, I would expect either complete failure to startup and a log message saying that it was missing, or a log message telling me that the ui login is now disabled (and the inability to hit /auth/login).

@VarvaraSemenova VarvaraSemenova self-assigned this Nov 28, 2023
@VarvaraSemenova VarvaraSemenova changed the title Startup should fail (or at minimum log) on necessary configuration Keebler: Startup should fail (or at minimum log) on necessary configuration Nov 28, 2023
@VarvaraSemenova VarvaraSemenova changed the title Keebler: Startup should fail (or at minimum log) on necessary configuration Startup should fail (or at minimum log) on necessary configuration Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement issues related to product improvement
Projects
None yet
Development

No branches or pull requests

3 participants