-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no visible ui on window #114
Comments
so this crashes version 33 too but you get back the ui when you launch it again |
Here's the output of it being broken |
Thank you for opening the issue! Does this still happen on v1.0.0-38? Also, is the output you posted the full output? It looks like the end might be a bit cut off. You could try running |
i should clarify the crash happens on both versions version 38 is the one with no ui so i would stuggle to get the output |
here is a log of agregore 38 having no UI i was able to find the search bar and navagate to google because my curser changed on a certain part of the screen but i could never see anything and i have no idea how i could open the extensions folder (i just remembered this browser has keybindings will try that) |
Interesting. I'm not sure what could be causing this. Would you be able to clone the repository and try running Also, what graphics card is this running on? I've tested with Intel graphics so far using X11. Not sure if other cards or Wayland could get in the way. |
https://gist.github.com/unmellow/355e1c7957f3d1e12eb7058854a693f1 Can't see the dev tools… |
using wayland fixes it so yeah i need to test some more things to see what is going on the issue could be electron or swaywm or agregore or xwayland hopefully testing it with gnome wayland should eliminate sway as the issue and testing it on x should eliminate xwayland but we will see |
this is a xwayland bug this problem apears when running on gnome wayland and swaywm wayland technically, something changed and caused this to happen but when testing electron with gnome on xorg with either of the aforementioned x11 renderers results in additionally, using the ozone platform Wayland renderer on gnome wayland and sway so i guess you could fix this but idk if it would be worth it to work around a bug in xwayland this all did result in me finding another bug with agregore though |
This might be a problem that was introduced to try to support the Pinephone. https://github.com/AgregoreWeb/agregore-browser/blob/master/app/main.js#L44 Is xwayland doing something weird where it sets |
XDG_SESSION_TYPE is always wayland unless I manually change it to x11 so electron by default uses x11 and ignores XDG_SESSION_TYPE electron --enable-features=UseOzonePlatform --ozone-platform=wayland /path/to/ElectronProgram so I think if you want to respect XDG_SESSION_TYPE you will need to wrap electron (at least that's how it would work for manjaro) with all this in mind i will now check if setting XDG_SESSION_TYPE to wayland on gnome xorg will have the same visual bug |
yes having XDG_SEESION_TYPE set to wayland without manually launching electron on native wayland causes as simple as that |
So I was having trouble getting Agregore working on Wayland. In order to do so, I had to reinstall electron and electron-rebuild #122 Electron, so it would stop crashing every time I hovered my mouse over the window. Electron-rebuild, so it would actually rebuild better-sqlite3 for the newer electron version. I don't know a good solution for this issue, but this came up as a problem while working on this |
Should add that with the latest version of agregore hyper urls don't work on windows ether I haven't tested my fork yet because idk how to dev on windows Should probably make a new bug for this |
Can confirm that this bug also exists on the default GNOME session on Fedora |
Is Fedora using Wayland for it's GNOME rendering? Does the advice in this comment work for you? |
Yes!
I haven't tried it yet. I'm guessing that command only works if you're running the app from source? |
Yes as far as I can tell appimage doesn't pass the params to electron so
you need to use source
…On Sun, Jan 16, 2022, 12:59 AM Aadil Ayub ***@***.***> wrote:
Is Fedora using Wayland for it's GNOME rendering?
Yes!
Does the advice in this comment work for you?
I haven't tried it yet. I'm guessing that command only works if you're
running the app from source?
—
Reply to this email directly, view it on GitHub
<#114 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHMM242Y3R4SS6S6ZNTKLHDUWJNFBANCNFSM5DAXJ7IQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
If you installed the app through Debian or something similar, you should be able to specify flags. I figured out how to add flags to the .desktop file for the app on the pinephone for example. |
Fedora 35 Workstation here. It’s using GNOME defaults, so Wayland by default. I get no UI when launching the app normally. Just an empty window and title bar.
Have you considered switching to a Flatpak deliverable for Linux? Then you control the entire runtime environment, so distros shouldn’t behave any differently from each other. I know this is the same promise as AppImages, but Flatpak lets you specify the window server the app runs in Wayland, Xwayland, or X11 mode. Plus, you get the security benefits of sandboxing etc. |
@da2x I'm currently using electron-builder to compile Agregore, and it doesn't seem to have a Flatpak option, however I'm down to switch to something else if I can also support existing platforms with it. By the way, does messing with any of these CLI flags change anything? https://github.com/AgregoreWeb/agregore-browser/blob/master/app/main.js#L40 Might be related to this electron issue? electron/electron#31885 Sadly I don't have anything running Wayland but my Pinephone, and I've been having other trouble on that front. 😅 |
If anyone with this issue could try cloning the repo and running from source, any errors you get would be very much appreciated. Maybe even try upgrading Electron to a newer version to see if that helps? |
btw their was a chrome regression that broke wayland support entirely because of a typo as far as i know even though chrome got the fix it has not been rolled out to electron and i have not been able to successfully roll back my electron version |
I think this might be fixed in the latest Electron version? Feel free to comment if it's still happening. |
OS : Manjaro Linux x86_64
kernel: 5.10.47-1-lts
I posted about this in discord when I opened the extension's directory, my window is now pale white
I can interact with the UI and see what page I am on through the terminal output
there is a way to get it back, but IDK how I did it before and can't seem to do it again
this is using the official Appimage
The text was updated successfully, but these errors were encountered: