From ae665f050ccc2f5790e7cc42346ac97ccb385829 Mon Sep 17 00:00:00 2001 From: Guilherme Ribeiro Date: Wed, 11 Sep 2024 15:25:00 +0200 Subject: [PATCH] Fixing Sonarcloud complains about ApplePayService (#2846) * sonarcloud reliability issues fix * changeset --- .changeset/tough-carrots-jog.md | 5 ++++ .../components/ApplePay/ApplePayService.ts | 27 +++++++++++++------ 2 files changed, 24 insertions(+), 8 deletions(-) create mode 100644 .changeset/tough-carrots-jog.md diff --git a/.changeset/tough-carrots-jog.md b/.changeset/tough-carrots-jog.md new file mode 100644 index 0000000000..3d54940d98 --- /dev/null +++ b/.changeset/tough-carrots-jog.md @@ -0,0 +1,5 @@ +--- +'@adyen/adyen-web': patch +--- + +Fixing reliability Sonarcloud issues related to ApplePayService diff --git a/packages/lib/src/components/ApplePay/ApplePayService.ts b/packages/lib/src/components/ApplePay/ApplePayService.ts index baeb014412..a2df61e09e 100644 --- a/packages/lib/src/components/ApplePay/ApplePayService.ts +++ b/packages/lib/src/components/ApplePay/ApplePayService.ts @@ -23,23 +23,34 @@ class ApplePayService { this.options = options; this.session = new ApplePaySession(options.version, paymentRequest); - /* eslint-disable @typescript-eslint/no-misused-promises */ - this.session.onvalidatemerchant = event => this.onvalidatemerchant(event, options.onValidateMerchant); - this.session.onpaymentauthorized = event => this.onpaymentauthorized(event, options.onPaymentAuthorized); - this.session.oncancel = event => this.oncancel(event, options.onCancel); + this.session.onvalidatemerchant = event => { + void this.onvalidatemerchant(event, options.onValidateMerchant); + }; + this.session.onpaymentauthorized = event => { + void this.onpaymentauthorized(event, options.onPaymentAuthorized); + }; + + this.session.oncancel = event => { + this.oncancel(event, options.onCancel); + }; if (typeof options.onPaymentMethodSelected === 'function') { - this.session.onpaymentmethodselected = event => this.onpaymentmethodselected(event, options.onPaymentMethodSelected); + this.session.onpaymentmethodselected = event => { + void this.onpaymentmethodselected(event, options.onPaymentMethodSelected); + }; } if (typeof options.onShippingContactSelected === 'function') { - this.session.onshippingcontactselected = event => this.onshippingcontactselected(event, options.onShippingContactSelected); + this.session.onshippingcontactselected = event => { + void this.onshippingcontactselected(event, options.onShippingContactSelected); + }; } if (typeof options.onShippingMethodSelected === 'function') { - this.session.onshippingmethodselected = event => this.onshippingmethodselected(event, options.onShippingMethodSelected); + this.session.onshippingmethodselected = event => { + void this.onshippingmethodselected(event, options.onShippingMethodSelected); + }; } - /* eslint-enable @typescript-eslint/no-misused-promises */ } /**