Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Update the PR Comment while a new build/deploy is happening after new commits are pushed to the PR #24

Open
pdellaert opened this issue Nov 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pdellaert
Copy link

pdellaert commented Nov 13, 2024

When using this action for PRs, it is uses a two step approach: build the PR, then trigger an action to deploy the build.

On the PR itself, it will show the build action, but not the deploy action, as the deploy action isn't directly triggered by the PR.

For new PRs, this isn't a big issue, the comment for the Preview deployment will show that it is still being deployed, until it actually has been deployed.

For PRs that get a new commit pushed, the comment continues to show that the preview has been deployed and shows the old commit hash. It only updates after the deploy phase is done. In itself this behavior is ok, but it can cause confusion: The build action shows completed (all actions on the PR show completed), but the Preview is still the old hash until the Deploy step has finished.

Ideally, the comment should be updated where it highlights a new build and deploy is running.

A potential approach could be:

  • On PR Commit push - Build action is triggered >> Comment is updated with a new (extra) row, showing that it is building/deploying and the commit hash of the one it is building. That way the old (available) Preview is still there, while there is a clear indication that a new build/deploy is running
  • On Build complete - Deploy action is triggered
    • (Optional) On Start - Comment is updated that build finished, and deploy is happening for the 2nd row
    • On successful Deploy - Comment is updated where the first row (old Preview) is removed, and the latest Preview shows as available, with the link etc. (and latest hash), just like today.

This would help people realize that there's still an action running, even though all the PR actions have finished.

PS: Absolutely love this action, thanks for this! :)

@AdrianGonz97 AdrianGonz97 added the enhancement New feature or request label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants