You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using this action for PRs, it is uses a two step approach: build the PR, then trigger an action to deploy the build.
On the PR itself, it will show the build action, but not the deploy action, as the deploy action isn't directly triggered by the PR.
For new PRs, this isn't a big issue, the comment for the Preview deployment will show that it is still being deployed, until it actually has been deployed.
For PRs that get a new commit pushed, the comment continues to show that the preview has been deployed and shows the old commit hash. It only updates after the deploy phase is done. In itself this behavior is ok, but it can cause confusion: The build action shows completed (all actions on the PR show completed), but the Preview is still the old hash until the Deploy step has finished.
Ideally, the comment should be updated where it highlights a new build and deploy is running.
A potential approach could be:
On PR Commit push - Build action is triggered >> Comment is updated with a new (extra) row, showing that it is building/deploying and the commit hash of the one it is building. That way the old (available) Preview is still there, while there is a clear indication that a new build/deploy is running
On Build complete - Deploy action is triggered
(Optional) On Start - Comment is updated that build finished, and deploy is happening for the 2nd row
On successful Deploy - Comment is updated where the first row (old Preview) is removed, and the latest Preview shows as available, with the link etc. (and latest hash), just like today.
This would help people realize that there's still an action running, even though all the PR actions have finished.
PS: Absolutely love this action, thanks for this! :)
The text was updated successfully, but these errors were encountered:
When using this action for PRs, it is uses a two step approach: build the PR, then trigger an action to deploy the build.
On the PR itself, it will show the build action, but not the deploy action, as the deploy action isn't directly triggered by the PR.
For new PRs, this isn't a big issue, the comment for the Preview deployment will show that it is still being deployed, until it actually has been deployed.
For PRs that get a new commit pushed, the comment continues to show that the preview has been deployed and shows the old commit hash. It only updates after the deploy phase is done. In itself this behavior is ok, but it can cause confusion: The build action shows completed (all actions on the PR show completed), but the Preview is still the old hash until the Deploy step has finished.
Ideally, the comment should be updated where it highlights a new build and deploy is running.
A potential approach could be:
This would help people realize that there's still an action running, even though all the PR actions have finished.
PS: Absolutely love this action, thanks for this! :)
The text was updated successfully, but these errors were encountered: