Regexp rule with $domain modifier doesn't work in 4.4 extension when the length of a domain is specified

[alexx7311]

Steps to reproduce:

1. Disable all filters
2. Go to User rules and add [$domain=/^webteizle\d{0,2}\.info/]##body
3. Open the filtering log on a new page and go to https://webteizle.info/izle/altyazi/justice-league-crisis-on-infinite-earths-part-one-w1

The rule should work on webteizle.info.

[Alex-302]

Also not working

[$domain=/exampl[exyz]+.com)/]##body
[$domain=/exampl[exyz]+\.com/]##body - works

[$domain=/example\.(com|org)/]##body

[scripthunter7]

@alexx7311

Its a known problem; in the case of some modifiers, we need special tokenization in the future, but in the meantime the comma should be escaped, e.g.

[$domain=/^webteizle\d{0\,2}\.info/]##body

[scripthunter7]

@Alex-302

[$domain=/exampl[exyz]+\.com)/]##body
!                           ↑ missing opening parenthesis
[$domain=/example\.(com|org)/]##body
!                      ↑ pipe should be escaped, otherwise $domain considers it as a separator

[Alex-302]

@scripthunter7 Isn't it separators check fail?

In uBO this regexp is valid
/example\.(com|org)/##body

[scripthunter7]

Isn't it separators check fail?

What do you mean?

In uBO this regexp is valid /example\.(com|org)/##body

We don't yet support this syntax

[Alex-302]

@scripthunter7 | is a part of regexp. Regexp with escaped $, |, , is not working in any other app. But this is required for AdGuard.

We don't yet support this syntax

I just tell about regexp, which works in UBO without "redundant" escaping.

missing opening parenthesis

Ok, this works
[$domain=/exampl[exyz]+\.com/]##body

[scripthunter7]

@Alex-302 Yes, we'll need a special tokenization that allows regexps to be used without such escape constraints. But for this, the operation of the network rule / modifier parser must be completely reworked, several edge cases must be handled, care must be taken to ensure that no new issues arise and the parsing speed must also be kept at an appropriate level, but regardless, this improvement is already planned, and there are already related issues in the tracker, I think we'll implement it soon

[Alex-302]

Great)