Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PX1011 diagnostic's code fix by removing virtual modifiers from DAC field properties in DAC extension #434

Open
SENya1990 opened this issue Apr 18, 2022 · 0 comments
Labels
enhancement New feature or request static analysis Items related to static code analysis

Comments

@SENya1990
Copy link
Contributor

Internal item number: ATR-631

The PX1011 diagnostic checks that DAC extension is marked as sealed to prevent creation of derived classes from it. Sometimes DAC extension contain DAC fields with virtual DAC field properties. Marking such extensions as sealed will lead to a compilation error.

We can improve the automated code fix so it won't break the compilation by removing virtual modifiers from DAC field properties in DAC extension.

@SENya1990 SENya1990 added enhancement New feature or request static analysis Items related to static code analysis labels Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request static analysis Items related to static code analysis
Projects
None yet
Development

No branches or pull requests

1 participant