Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Error on invalid BQL / FBQL in typeof()? #404

Open
ldrick opened this issue Sep 16, 2021 · 1 comment
Open

Give Error on invalid BQL / FBQL in typeof()? #404

ldrick opened this issue Sep 16, 2021 · 1 comment
Labels
enhancement New feature or request static analysis Items related to static code analysis

Comments

@ldrick
Copy link

ldrick commented Sep 16, 2021

We had created a bug in a DAC, without noticing, which might be possible for Acuminator to detect upfront.

This was how we wrongly mixed syntax in DAC field Attribute (and it is not detected by Visual Studio, as this is happening inside typeof():

 [PXParent(typeof(Select<InventoryItem,
            Where<InventoryItem.inventoryID
                    .IsEqual<PTINItemCommodityCode.inventoryID.FromCurrent>>>))]

This is correct for FBQL:

[PXParent(typeof(SelectFrom<InventoryItem>.Where<InventoryItem.inventoryID
                    .IsEqual<PTINItemCommodityCode.inventoryID.FromCurrent>>))]

Might be a good place for Acuminator to kick in and safe us from doing invalid BQL or FBQL.
Thank you for your great work.

@SENya1990 SENya1990 added the enhancement New feature or request label Sep 16, 2021
@SENya1990
Copy link
Contributor

Thanks for the proposal. We will add a suggestion to check that BQL and FBQL are not mixed to the list of new features considered for Acuminator

@SENya1990 SENya1990 added the static analysis Items related to static code analysis label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request static analysis Items related to static code analysis
Projects
None yet
Development

No branches or pull requests

2 participants