-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting: Remove white space before formatting #208
Labels
Comments
@jflin404 I have created a bug for this issue. I'm not sure that I have correctly understood your problem. Do you have a problem with the BQL Formatter when you format this query:
And the bug is reproduced by following these steps?
I can't understand the text that goes after. Could you please provide more details? |
Certainly!
I'd like the text to be formatted the same way, regardless of whitespace
going in. (E.g. some people put a linefeed after a bracket, like to get
team on same looking BQL)
Formatted from the one line:
In:
"public PXFilteredProcessingJoin< MQMJVegDet, ProcessFilterSend,
InnerJoin<MQMJVegHdr, On<MQMJVegHdr.vegID, Equal<MQMJVegDet.vegID>>>,
Where2< Where<MQMJVegHdr.strainID, Equal<Current<ProcessFilterSend.strainID>>,
Or<Current<ProcessFilterSend.strainID>, IsNull>>,
And<MQMJVegDet.sentDateTime, IsNull, And<MQMJVegHdr.status,
Equal<StatusList.closed>>>>> Records;
"
Formatted:
"
public PXFilteredProcessingJoin<
MQMJVegDet, ProcessFilterSend,
InnerJoin<MQMJVegHdr,
On<MQMJVegHdr.vegID, Equal<MQMJVegDet.vegID>>>,
Where2<
Where<MQMJVegHdr.strainID,
Equal<Current<ProcessFilterSend.strainID>>,
Or<Current<ProcessFilterSend.strainID>, IsNull>>,
And<MQMJVegDet.sentDateTime, IsNull,
And<MQMJVegHdr.status, Equal<StatusList.closed>>>>>
Records;
"
Try two:
In (Add one CRLF in visual studio, after the 2nd > after .closed:
"
public PXFilteredProcessingJoin<MQMJVegDet, ProcessFilterSend,
InnerJoin<MQMJVegHdr, On<MQMJVegHdr.vegID, Equal<MQMJVegDet.vegID>>>,
Where2<Where<MQMJVegHdr.strainID,
Equal<Current<ProcessFilterSend.strainID>>,
Or<Current<ProcessFilterSend.strainID>, IsNull>>,
And<MQMJVegDet.sentDateTime, IsNull, And<MQMJVegHdr.status,
Equal<StatusList.closed>>
>> Records;
"
Formatted:
"
public PXFilteredProcessingJoin<
MQMJVegDet, ProcessFilterSend,
InnerJoin<MQMJVegHdr,
On<MQMJVegHdr.vegID, Equal<MQMJVegDet.vegID>>>,
Where2<
Where<MQMJVegHdr.strainID,
Equal<Current<ProcessFilterSend.strainID>>,
Or<Current<ProcessFilterSend.strainID>, IsNull>>,
And<MQMJVegDet.sentDateTime, IsNull,
And<MQMJVegHdr.status, Equal<StatusList.closed>>
>>
Records;
"
Notice now have a line with just 3 >, rather than "Closing it up" back to "
.closed>>>>>"
I'd classify more as an enhancement than a bug, but up to you
Acuminator version 1.5.0
Visual Studio 2017, version 15.9.8
…On Fri, Mar 15, 2019 at 5:23 AM Sergey Nikomarov ***@***.***> wrote:
@jflin404 <https://github.com/jflin404> I have created a bug for this
issue. I'm not sure that I have correctly understood your problem. Do you
have a problem with the BQL Formatter when you format this query:
public PXFilteredProcessingJoin< MQMJVegDet, ProcessFilterSend, InnerJoin<MQMJVegHdr, On<MQMJVegHdr.vegID, Equal<MQMJVegDet.vegID>>>, Where2< Where<MQMJVegHdr.strainID, Equal<Current<ProcessFilterSend.strainID>>, Or<Current<ProcessFilterSend.strainID>, IsNull>>, And<MQMJVegDet.sentDateTime, IsNull, And<MQMJVegHdr.status, Equal<StatusList.closed>>>>> Records;
And the bug is reproduced by following these steps?
Paste code in editor, run format
Add a return between two > (your choice which)
Re-Format, now looks different
I can't understand the text that goes after. Could you please provide more
details?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#208 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AuUXpn-hMkhB6KnzKUYPA_tE4CbA7ZXTks5vW2Z1gaJpZM4b1Evf>
.
|
SENya1990
added
bug
Something isn't working
BQL Formatter
Items related to BQL Formatter
labels
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sample code ,with whitespace minimal:
public PXFilteredProcessingJoin< MQMJVegDet, ProcessFilterSend, InnerJoin<MQMJVegHdr, On<MQMJVegHdr.vegID, Equal<MQMJVegDet.vegID>>>, Where2< Where<MQMJVegHdr.strainID, Equal<Current<ProcessFilterSend.strainID>>, Or<Current<ProcessFilterSend.strainID>, IsNull>>, And<MQMJVegDet.sentDateTime, IsNull, And<MQMJVegHdr.status, Equal<StatusList.closed>>>>> Records;
Duplicate by:
Paste code in editor, run format
Add a return between two > (your choice which)
Re-Format, now looks different
Since formatting is "Fixed"
Single Space -> Character 9
CR/LF -> 78
Format 1:
public9PXFilteredProcessingJoin<78999999999999999999999999999999999999999999999999999999999999MQMJVegDet,789999999999999999999999999999999999999999ProcessFilterSend,78999999999999999999999999999999999999999999999999999999999999InnerJoin<MQMJVegHdr,9789999999999999999999999999999999999999999999999999999999999999999On<MQMJVegHdr.vegID,9Equal<MQMJVegDet.vegID>>>,78999999999999999999999999999999999999999999999999999999999999Where2<789999999999999999999999999999999999999999999999999999999999999999Where<MQMJVegHdr.strainID,9Equal<Current<ProcessFilterSend.strainID>>,7899999999999999999999999999999999999999999999999999999999999999999999Or<Current<ProcessFilterSend.strainID>,9IsNull>>,789999999999999999999999999999999999999999999999999999999999999999And<MQMJVegDet.sentDateTime,9IsNull,789999999999999999999999999999999999999999999999999999999999999999And<MQMJVegHdr.status,9Equal<StatusList.closed>>>>78999999999999999999999999999999999999999999999999999999>78999999999999999999999999999999999999999999999999999999999999Records;
Add ONE carriage return after Closed:
99999999public9PXFilteredProcessingJoin<78999999999999999999999999999999999999999999999999999999999999MQMJVegDet,789999999999999999999999999999999999999999ProcessFilterSend,78999999999999999999999999999999999999999999999999999999999999InnerJoin<MQMJVegHdr,9789999999999999999999999999999999999999999999999999999999999999999On<MQMJVegHdr.vegID,9Equal<MQMJVegDet.vegID>>>,78999999999999999999999999999999999999999999999999999999999999Where2<789999999999999999999999999999999999999999999999999999999999999999Where<MQMJVegHdr.strainID,9Equal<Current<ProcessFilterSend.strainID>>,7899999999999999999999999999999999999999999999999999999999999999999999Or<Current<ProcessFilterSend.strainID>,9IsNull>>,789999999999999999999999999999999999999999999999999999999999999999And<MQMJVegDet.sentDateTime,9IsNull,789999999999999999999999999999999999999999999999999999999999999999And<MQMJVegHdr.status,9Equal<StatusList.closed>>>789999999999999999999999999999999999999999999999999999999999999999>78999999999999999999999999999999999999999999999999999999>78999999999999999999999999999999999999999999999999999999999999Records;
Manually remove whitespace:
public9PXFilteredProcessingJoin<78999999999999999999999999999999999999999999999999999999999999MQMJVegDet,9ProcessFilterSend,78999999999999999999999999999999999999999999999999999999999999InnerJoin<MQMJVegHdr,789999999999999999999999999999999999999999999999999999999999999999On<MQMJVegHdr.vegID,9Equal<MQMJVegDet.vegID>>>,78999999999999999999999999999999999999999999999999999999999999Where2<789999999999999999999999999999999999999999999999999999999999999999Where<MQMJVegHdr.strainID,9Equal<Current<ProcessFilterSend.strainID>>,97899999999999999999999999999999999999999999999999999999999999999999999Or<Current<ProcessFilterSend.strainID>,9IsNull>>,9789999999999999999999999999999999999999999999999999999999999999999And<MQMJVegDet.sentDateTime,9IsNull,9789999999999999999999999999999999999999999999999999999999999999999And<MQMJVegHdr.status,9Equal<StatusList.closed>>>>>978999999999999999999999999999999999999999999999999999999999999Records;
The text was updated successfully, but these errors were encountered: