Add Arc browser data in Timeline > Browser tab #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ef85adc in 14 seconds
More details
- Looked at
21lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/queries.ts:292
- Draft comment:
The logic for finding the Chrome bucket for Arc browser can be simplified by directly checking for 'arc' in the bucket_id. This avoids the need for a separate chrome_bucket variable. - Reason this comment was not posted:
Confidence changes required:50%
The code correctly identifies Arc browser using Chrome's bucket, but the logic can be simplified.
Workflow ID: wflow_fNKmp6MsmTN5RjyK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
/activity/Mac/view/browserwill not display Arc browser data, despite that data already appearing in the/#/timelinetab. This fixes the issue.We fix this by just pushing all the Arc browser data to the chrome bucket for purposes of visualization. While not a perfect solution, it is an easy one, and far superior to not displaying that data at all.
This issue is known:
fixes ActivityWatch/activitywatch#1094
This fix can be extended to support Brave/Vivaldi/etc, without relying on custom browser identification hacks. The tradeoff (obviously) is that all browsers' data based on chromium gets merged I guess.
@ErikBjare if you have time would love a quick look :)
Important
Fixes Arc browser data display issue by associating it with Chrome's bucket in
queries.ts./activity/Mac/view/browserby associating Arc with Chrome's bucket inbrowsersWithBuckets()inqueries.ts.browser_appnamesinqueries.ts.This description was created by
for ef85adc. It will automatically update as commits are pushed.