Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count ETupProject projlen differently / replace with simpler tuple indexing #22

Open
rrnewton opened this issue Jul 7, 2014 · 1 comment

Comments

@rrnewton
Copy link
Member

rrnewton commented Jul 7, 2014

We are using surface tuples throughout accelerate-backend kit, including decoding the EltRepr to recover the surface structure (which doesn't help us with shapes, alas).

However, there's an inconsistency here, because we count projlen in ETupProject in terms of scalar leaves. If we are sticking with surface, N-array tuples, then this should be replaced with a basic "project field N of M" operator, and this should be able to happen from when we first build SimpleAcc.

@svenssonjoel
Copy link
Contributor

I think this is related to some recent work we did. We took a different approach and are now using the
same count the leaves approach on array tuples. At least this means that it is now consistent.

Maybe Trevor has more input to offer here, but I think we got to a point where said "oh, we cannot do it the surface type way".

I don't want to close this issue with comment, but rather await your thought/review on our approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants