Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RESTful HTTP endpoints in Menas API #966

Closed
GeorgiChochov opened this issue Oct 8, 2019 · 1 comment
Closed

Use RESTful HTTP endpoints in Menas API #966

GeorgiChochov opened this issue Oct 8, 2019 · 1 comment
Labels
duplicate This issue or pull request already exists feature New feature Menas Menas component affected priority: medium Important but not urgent

Comments

@GeorgiChochov
Copy link
Collaborator

GeorgiChochov commented Oct 8, 2019 •
edited by dk1844
Loading

Background

Currently, the Menas API has endpoints specified as verbs (.../create, .../edit), this does not fit a RESTful API.

Also, correct return codes should be used (e.g. /edit returns now 201 Created).

Feature

The endpoints for a resource should be consistent while the HTTP method determines the operation performed on the resource.

Example [Optional]

GET .../dataset/list -> GET .../dataset
POST .../dataset/create -> POST .../dataset
POST .../dataset/x/y/edit -> PUT .../dataset/x/y
POST .../dataset/x/y/disable -> DELETE .../dataset/x/y
@GeorgiChochov GeorgiChochov added feature New feature Menas Menas component affected priority: medium Important but not urgent labels Oct 8, 2019
@GeorgiChochov GeorgiChochov self-assigned this Oct 8, 2019
@GeorgiChochov GeorgiChochov modified the milestone: 3.0.0 Dec 11, 2019
@benedeki
Copy link
Collaborator

Part of #1693

@benedeki benedeki added the duplicate This issue or pull request already exists label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists feature New feature Menas Menas component affected priority: medium Important but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benedeki @GeorgiChochov