Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Process and Transfer more robust in hyp3-nasa-disasters (pin dependencies, fail for errors) #129

Closed
jtherrmann opened this issue Aug 26, 2024 · 1 comment
Labels
Jira Bug Create a Jira Bug for this issue

Comments

@jtherrmann
Copy link
Contributor

jtherrmann commented Aug 26, 2024

Jira: https://asfdaac.atlassian.net/browse/TOOL-2989

Note: The above link is accessible only to members of ASF.


We should make the process-and-transfer workflow more robust. A recent string of failures that went unnoticed for 3 weeks highlighted two areas for improvement:

  1. Move the dependencies for data_management/environment.yml to a requirements file, pin the versions, and confirm that dependabot is tracking those requirements. To fix the recent string of failures, I've pinned asf_search in the environment file, but dependabot won't keep track of it.
  2. Ensure that errors (e.g. unhandled Python exceptions) within a job cause the job to fail. For example this run shows 4 successful jobs with 4 "Annotations" for errors caused by an unhandled Python exception. I think there's a GitHub Actions settings to ensure that jobs fail when commands within the job return an error code?
@jtherrmann jtherrmann added the Jira Bug Create a Jira Bug for this issue label Aug 26, 2024
@deverchettychandrashekar

This comment was marked as spam.

@deverchettychandrashekar

This comment was marked as spam.

@jtherrmann
Copy link
Contributor Author

jtherrmann commented Dec 9, 2024

We should see a dependabot PR opened to bump asf-search.

Edit: #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Bug Create a Jira Bug for this issue
Projects
None yet
Development

No branches or pull requests

6 participants
@jtherrmann @deverchettychandrashekar and others