Typo in component-anchor.js?

[JohnGrime]

Do you want to request a feature or report a bug?

Report a bug (potential?)

What is the current behavior?

In AR.js/aframe/src/component-anchor.js, line 118 reads:

AR.js/aframe/src/component-anchor.js

Line 118 in aaad984

markerParameters.minConfidence = _this.data.minCondidence;

The use of _this.data.minCondidence looks like a typo to me, and I can't find any reference to a minCondidence member elsewhere.

If the current behavior is a bug, please provide the steps to reproduce.

N/A

Please mention other relevant information such as the browser version, Operating System and Device Name

N/A

What is the expected behavior?

I guess I'd expect line 188 instead to read:

markerParameters.minConfidence = _this.data.minConfidence;

If this is a feature request, what is motivation or use case for changing the behavior?

[kalwalt]

Yes, @JohnGrime you are right we have fixed in ES6 branch

AR.js/aframe/src/component-anchor.js

Line 123 in d998a44

markerParameters.minConfidence = _this.data.minConfidence;

see PR #116 but not in master nor in dev yet. I will see if make a fix or waiting to merge the ES6 into dev ( we are very close!).
Anyway tahnks for reporting the bug!

[kalwalt]

The fix for this is merged on the dev branch and soon i hope to merge into the master. Closing this issue, and thanks again @JohnGrime for reporting.