Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup Dataset RolePaths - relative or absolute? #19

Closed
jonathan-r-thorpe opened this issue Oct 7, 2024 · 2 comments
Closed

Backup Dataset RolePaths - relative or absolute? #19

jonathan-r-thorpe opened this issue Oct 7, 2024 · 2 comments
Labels
triage Apply to all new issues

Comments

@jonathan-r-thorpe
Copy link
Contributor

In the backup dataset are the role paths relative or explicit?

Explicit:

  • You always know to which part of the Device Model the backup dataset relates
  • It doesn't matter what the target of the backup dataset it as you can apply the backup dataset to any role path.

Relative:

  • The backup dataset can be applied more flexibly
  • The target of the backup dataset matters, as each role path is relative to the target.

My assumption is that the role paths would be relative but either way this needs to be stated in the specification to avoid confusion.

@github-actions github-actions bot added the triage Apply to all new issues label Oct 7, 2024
@cristian-recoseanu
Copy link
Contributor

I think the role path in a NcObjectPropertiesHolder has to be absolute as it is expressed in the NcBulkValuesHolder as a flat collection in the values field.

interface NcBulkValuesHolder {
    attribute NcString?    validationFingerprint; // Optional vendor specific fingerprinting mechanism used for validation purposes
    attribute sequence<NcObjectPropertiesHolder>    values; // Values by rolePath
};

This also matches the response from the /rolePaths endpoint which returns absolute paths.

I agree we should explicitly mention in the specs that this is the case.

@jonathan-r-thorpe
Copy link
Contributor Author

Great. Also it would be worth noting in the specification that the absolute paths means you can apply the backup to any of the role path endpoints.

However, perhaps worth recommending to apply it to rolePaths/root/bulkProperties ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Apply to all new issues
Projects
None yet
Development

No branches or pull requests

2 participants