From c0e43a54578e45fc6a1b337e40b1f22c134f9789 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20N=C3=BCrnberger?= Date: Tue, 4 Feb 2025 13:17:25 +0100 Subject: [PATCH 1/2] allow other PKs such as uuid --- src/Traits/HasEmbeddings.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Traits/HasEmbeddings.php b/src/Traits/HasEmbeddings.php index 3655fce..e071a26 100644 --- a/src/Traits/HasEmbeddings.php +++ b/src/Traits/HasEmbeddings.php @@ -24,7 +24,7 @@ public function embed(string $key, string $content): bool foreach ($embeddings as $embedding) { $embedding->key = $key; $embedding->embeddable_type = static::class; - $embedding->embeddable_id = $this->id; + $embedding->embeddable_id = $this->getKey(); $embedding->save(); From 07f990eb3b3f26f9ebf080f8034ba913164aec49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20N=C3=BCrnberger?= Date: Tue, 4 Feb 2025 13:17:54 +0100 Subject: [PATCH 2/2] fix autocompletion --- src/Traits/HasEmbeddings.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Traits/HasEmbeddings.php b/src/Traits/HasEmbeddings.php index e071a26..b4c3faa 100644 --- a/src/Traits/HasEmbeddings.php +++ b/src/Traits/HasEmbeddings.php @@ -6,6 +6,9 @@ use Ada\Jobs\EmbedJob; use Ada\Models\Embedding; +/** + * @mixin \Illuminate\Database\Eloquent\Model + */ trait HasEmbeddings { public function embed(string $key, string $content): bool