Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests e2e Playwright base layers: mocking tiles #5340

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Feb 3, 2025

To speed up end2end playwright base layers tests, OSM and GeoPF tiles has been saved and mocked.

We have save the real tiles because, these tests checking that tiles are well drawn in OL map.

@rldhont rldhont added tests unit tests and docker configuration for tests refactoring run end2end If the PR must run end2end tests or not backport release_3_8 backport release_3_9 labels Feb 3, 2025
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, minor comment, otherwise LGTM

tests/end2end/playwright/base-layers.spec.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the 3.10.0 milestone Feb 3, 2025
To speed up end2end playwright base layers tests, OSM and GeoPF tiles has been saved and mocked.
We have save the real tiles because, these tests checking that tiles are well drawn in OL map.
@rldhont rldhont force-pushed the tests-e2e-base-layers-mock branch from 90b43c3 to 071b594 Compare February 3, 2025 16:46
Instead of contine route requests when the mocking file is unknown, fulfill route requests with default tile.
@rldhont
Copy link
Collaborator Author

rldhont commented Feb 4, 2025

@Gustry I have added a commit with default tiles.

@Gustry Gustry merged commit aefa5b0 into 3liz:master Feb 4, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_8 backport release_3_9 refactoring run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants