JS Map - Use native zoom levels

[rldhont]

For EPSG:3857 and others if only 2 scales are defined, the native zoom levels are used for the Map.

Some legacy codes are removed.

FUnded by 3Liz

[Gustry]

As discussed together about the print, KISS : same projection everywhere ?

Linked to PR 3liz/lizmap-plugin#526

[Gustry]

Trying to sum up the conversation from yesterday :

version <= 3.6 :

• nothing changed
• CFG configuration like existing

•        use_native_scales: false, 
        "mapScales": [
            100,
            500,
            1000,
            2500,
            5000,
            10000,
            25000,
            50000,
            100000,
            250000,
            500000
        ],
        "minScale": 100,
        "maxScale": 500000,

Version >= 3.7

• checkbox "Use native".
• If checked :
  • users must set min and max
  • scales list is hidden
• If unchecked :
  • min and max readonly
  • scales list editable
  • min and max readonly because determined from scales list
  • no more warning like screenshot above
  • Only if the scale list is displayed, show the information text about print ?

  •     use_native_scales: true
        "mapScales": [
            100,
            500000
        ],
        "minScale": 100,
        "maxScale": 500000,

    Still mapscales with only max items ?

[Gustry]

I'm trying the PR. Looks good !

Side question, whatever the checkbox about native scales, if the map list has only two values, we have native, right ?

[Gustry]

Side question, whatever the checkbox about native scales, if the map list has only two values, we have native, right ?

According to JS code, it seems not, but anyway, very rare to have only two values in this list.

https://github.com/3liz/lizmap-web-client/pull/4007/files#diff-0da40e308a26999f09137dd8e1062f96599436c1d67d4c1289054d4494539659R204

[rldhont]

@nboisteault @Gustry ready for reiews

[rldhont]

Linked to 3liz/lizmap-plugin#537

[Gustry]

Side question, whatever the checkbox about native scales, if the map list has only two values, we have native, right ?

Indeed, it doesn't happen anymore.

LGTM for me

[Gustry]

From the test side

[nboisteault]

👍

[3liz-bot]

The backport to release_3_7 failed:

The process '/usr/bin/git' failed with exit code 1

stderr

error: could not apply 6678ebfdd... JS: Use native zoom levels
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

stdout

Auto-merging assets/src/legacy/map.js
CONFLICT (content): Merge conflict in assets/src/legacy/map.js

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4007-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6678ebfdd3f81235212cdd1ede253e8ec0420395,f9008de2aa03c4c0d7375b7a606ff9f6f9bd076e,1beeb89fa3145bcd084802cec15bf9bf9bccbf77,c3a45ca933058adec2439ace7f60e7cae6e432fc,3da806b6ee0b8be59931bc01c35050d1809235cb,50d383d24cac91054deaeeeaac26b3ab538deef1,6255665daf1de9f53b2dbbd9d420af113bb25c8c
# Push it to GitHub
git push --set-upstream origin backport-4007-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7

Then, create a pull request where the base branch is release_3_7 and the compare/head branch is backport-4007-to-release_3_7.